Skip to content

gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check#5649

Open
priyaranjannanda wants to merge 2 commits into
openconfig:mainfrom
priyaranjannanda:gNMI-1.10_4
Open

gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check#5649
priyaranjannanda wants to merge 2 commits into
openconfig:mainfrom
priyaranjannanda:gNMI-1.10_4

Conversation

@priyaranjannanda

Copy link
Copy Markdown
Contributor
  • Added PTX10002-36QDD for skipping Fabric check

@priyaranjannanda priyaranjannanda requested a review from a team as a code owner July 1, 2026 16:36
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the telemetry basic check test to include the PTX10002-36QDD hardware platform in the exclusion list for fabric checks. This ensures that the test correctly handles hardware platform compatibility for this specific device model.

Highlights

  • Hardware Compatibility: Added the PTX10002-36QDD model to the list of devices that skip the fabric check in the telemetry basic check test.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Jul 1, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5649 / 5dc619c

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.10: Telemetry: Basic Check
Cisco 8000E status
gNMI-1.10: Telemetry: Basic Check
Cisco XRd status
gNMI-1.10: Telemetry: Basic Check
Juniper ncPTX status
gNMI-1.10: Telemetry: Basic Check
Nokia SR Linux status
gNMI-1.10: Telemetry: Basic Check
Openconfig Lemming status
gNMI-1.10: Telemetry: Basic Check

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-1.10: Telemetry: Basic Check
Cisco 8808 status
gNMI-1.10: Telemetry: Basic Check
Juniper PTX10008 status
gNMI-1.10: Telemetry: Basic Check
Nokia 7250 IXR-10e status
gNMI-1.10: Telemetry: Basic Check

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the 'PTX10002-36QDD' hardware model to the skip list in 'TestComponentParent' due to compatibility issues. The feedback advises adding a 'TODO' comment with a link to an issue tracker to document this temporary model-specific check, as required by the repository's style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants