Skip to content

gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyaranjannanda wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check #5649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b876d5f
gNMI-1.10 Added PTX10002-36QDD for skipping Fabric check
priyaranjannanda Jul 1, 2026
5dc619c
Merge branch 'main' into gNMI-1.10_4
priyaranjannanda Jul 2, 2026
69d7e0b
Merge branch 'main' into gNMI-1.10_4
priyaranjannanda Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ func TestComponentParent(t *testing.T) {
for _, tc := range cases {
t.Run(tc.desc, func(t *testing.T) {

if len(compList[tc.desc]) == 0 && (dut.Model() == "DCS-7280CR3K-32D4" || dut.Model() == "CISCO-8202-32FH-M") {
if len(compList[tc.desc]) == 0 && (dut.Model() == "DCS-7280CR3K-32D4" || dut.Model() == "CISCO-8202-32FH-M" || dut.Model() == "PTX10002-36QDD") {

@gemini-code-assist gemini-code-assist Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding model-specific checks directly in the test file is discouraged. According to the repository's general rules, temporary vendor-specific or model-specific checks are acceptable in test files only if they are accompanied by a TODO comment and a link to an issue tracker, while waiting for a formal deviation to be introduced. Please add a TODO comment with a tracking issue URL.

			// TODO: PTX10002-36QDD does not support certain components. Move this to a deviation once confirmed.
			// https://github.com/openconfig/featureprofiles/issues/XXXXX
			if len(compList[tc.desc]) == 0 && (dut.Model() == "DCS-7280CR3K-32D4" || dut.Model() == "CISCO-8202-32FH-M" || dut.Model() == "PTX10002-36QDD") {
References
  1. Use deviations to allow alternate OC paths or CLI commands to achieve the same operational intent. Do not use them to skip validation or change the intent of the test. (link)
  2. Temporary vendor-specific checks (e.g., checking dut.Vendor()) are acceptable in test files if they are accompanied by a TODO comment and a link to an issue tracker, while waiting for the vendor to confirm the behavior and formally introduce a deviation.

t.Skipf("Test of %v is skipped due to hardware platform compatibility", tc.componentType)
}

Expand Down
Loading