-
Notifications
You must be signed in to change notification settings - Fork 227
Certz-1.1 and Certz-1.2 #5653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sudhirakondi
wants to merge
15
commits into
openconfig:main
Choose a base branch
from
priyacj:certz1.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Certz-1.1 and Certz-1.2 #5653
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4f709d7
updated the gofiles.
priyacj f1146a1
update
sudhirakondi 62d5d17
Merge branch 'openconfig:main' into certz1.1
priyacj 0f75cb5
Merge branch 'openconfig:main' into certz1.1
priyacj 4ea202f
Merge branch 'openconfig:main' into certz1.1
priyacj 6aca6f2
addressed the gemini review feedback
priyacj 87da380
Merge branch 'openconfig:main' into certz1.1
priyacj 818036d
Merge branch 'main' into certz1.1
priyacj 5f4a3c1
Merge branch 'openconfig:main' into certz1.1
priyacj 65d9c1e
Merge branch 'openconfig:main' into certz1.1
priyacj f4c10a4
Merge branch 'openconfig:main' into certz1.1
priyacj 3882de6
Merge branch 'openconfig:main' into certz1.1
priyacj 23621e5
Merge branch 'main' into certz1.1
priyacj 9eb5a88
Merge branch 'openconfig:main' into certz1.1
priyacj dcf1766
Merge branch 'main' into certz1.1
sudhirakondi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
311 changes: 311 additions & 0 deletions
311
feature/gnsi/certz/tests/client_certificates/client_certificates_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,311 @@ | ||
| // Copyright 2024 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package client_certificates_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/tls" | ||
| "crypto/x509" | ||
| "flag" | ||
| "fmt" | ||
| "slices" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/openconfig/featureprofiles/feature/gnsi/certz/tests/internal/setup_service" | ||
| "github.com/openconfig/featureprofiles/internal/fptest" | ||
| "github.com/openconfig/gnmi/proto/gnmi" | ||
| certzpb "github.com/openconfig/gnsi/certz" | ||
| "github.com/openconfig/ondatra" | ||
| "github.com/openconfig/ondatra/binding" | ||
| ) | ||
|
|
||
| const ( | ||
| dirPath = "../../test_data/" | ||
| ) | ||
|
|
||
| // DUTCredentialer is an interface for getting credentials from a DUT binding. | ||
| type DUTCredentialer interface { | ||
| RPCUsername() string | ||
| RPCPassword() string | ||
| } | ||
|
|
||
| func TestMain(m *testing.M) { | ||
| fptest.RunTests(m) | ||
| } | ||
|
|
||
| // TestClientCert Test validates that client certificates from a set of one CA are able to be loaded successfully | ||
| // and used for authentication to a device when used by a client connecting to each | ||
| // gRPC service. | ||
| func TestClientCert(t *testing.T) { | ||
|
|
||
| var ( | ||
| serverAddr string | ||
| creds DUTCredentialer //an interface for getting credentials from a DUT binding | ||
| testProfile string = "newprofile" //sslProfileId name | ||
| prevClientCertFile string = "" | ||
| prevClientKeyFile string = "" | ||
| prevTrustBundleFile string = "" | ||
| expectedResult bool = true | ||
| certsList = flag.String("certsList", "01,02,10,1000", "Number of Certificate Sets to generate for this test. Comma separated string") | ||
| certsTimeout = flag.Duration("certsTimeout", 10*time.Minute, "Time duration for cert generation and cleanup. Increase if more certs are to be generated") | ||
| ) | ||
| dut := ondatra.DUT(t, "dut") | ||
| serverAddr = dut.Name() //returns the device name. | ||
| if err := binding.DUTAs(dut.RawAPIs().BindingDUT(), &creds); err != nil { | ||
| t.Fatalf("STATUS:Failed to get DUT credentials using binding.DUTAs: %v. The binding for %s must implement the DUTCredentialer interface.", err, dut.Name()) | ||
| } | ||
| username := creds.RPCUsername() | ||
| password := creds.RPCPassword() | ||
| t.Logf("Validation of all services that are using gRPC before certz rotation.") | ||
| gnmiClient, gnsiC := setup_service.PreInitCheck(context.Background(), t, dut) | ||
| //Generate testdata certificates | ||
| //Registering the cleanup before the certificate generation call, so it runs even if certificate generation fails. | ||
| t.Cleanup(func() { | ||
| t.Logf("STATUS:Cleanup of test data.") | ||
| if err := setup_service.TestdataMakeCleanup(t, dirPath, *certsTimeout, "./cleanup.sh"); err != nil { | ||
| t.Logf("STATUS:Cleanup of testdata certificates failed!: %v", err) | ||
| } | ||
| }) | ||
| t.Logf("STATUS:Generation of testdata certificates begins.") | ||
| command := fmt.Sprintf("./mk_cas.sh %v", *certsList) | ||
| if err := setup_service.TestdataMakeCleanup(t, dirPath, *certsTimeout, command); err != nil { | ||
| t.Fatalf("STATUS:Generation of testdata certificates failed!: %v", err) | ||
| } | ||
| //Create a certz client | ||
| ctx := context.Background() | ||
| certzClient := gnsiC.Certz() | ||
| t.Logf("STATUS:Precheck:checking baseline ssl profile list.") | ||
| //Get ssl profile list. | ||
| if getResp := setup_service.GetSslProfilelist(ctx, t, certzClient, &certzpb.GetProfileListRequest{}); slices.Contains(getResp.SslProfileIds, testProfile) { | ||
| t.Fatalf("STATUS:profileID %s already exists.", testProfile) | ||
| } | ||
| //Add a new ssl profileID | ||
| t.Logf("STATUS:Adding new empty ssl profile ID %s.", testProfile) | ||
| if addProfileResponse, err := certzClient.AddProfile(ctx, &certzpb.AddProfileRequest{SslProfileId: testProfile}); err != nil { | ||
| t.Fatalf("STATUS:Add profile request failed with %v!", err) | ||
| } else { | ||
| t.Logf("STATUS:Received the AddProfileResponse %v.", addProfileResponse) | ||
| } | ||
| //Get ssl profile list after new ssl profile addition. | ||
| if getResp := setup_service.GetSslProfilelist(ctx, t, certzClient, &certzpb.GetProfileListRequest{}); !slices.Contains(getResp.SslProfileIds, testProfile) { | ||
| t.Fatalf("STATUS:newly added profileID %s is not seen.", testProfile) | ||
| } else { | ||
| t.Logf("STATUS: new profileID %s is seen in ssl profile list.", testProfile) | ||
| } | ||
| cases := []struct { | ||
| desc string | ||
| serverCertFile string | ||
| serverKeyFile string | ||
| trustBundleFile string | ||
| clientCertFile string | ||
| clientKeyFile string | ||
| cversion string | ||
| bversion string | ||
| newTLScreds bool | ||
| mismatch bool | ||
| scale bool | ||
| }{ | ||
| { | ||
| desc: "Certz1.1:Load the key-type rsa trustbundle with 1 CA configuration", | ||
| serverCertFile: dirPath + "ca-01/server-rsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-01/server-rsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-01/trust_bundle_01_rsa.p7b", | ||
| clientCertFile: dirPath + "ca-01/client-rsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-01/client-rsa-a-key.pem", | ||
| cversion: "certz1", | ||
| bversion: "bundle1", | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type ecdsa trustbundle with 1 CA configuration", | ||
| serverCertFile: dirPath + "ca-01/server-ecdsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-01/server-ecdsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-01/trust_bundle_01_ecdsa.p7b", | ||
| clientCertFile: dirPath + "ca-01/client-ecdsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-01/client-ecdsa-a-key.pem", | ||
| cversion: "certz2", | ||
| bversion: "bundle2", | ||
| newTLScreds: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type rsa trustbundle with 2 CA configuration", | ||
| serverCertFile: dirPath + "ca-02/server-rsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-02/server-rsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-02/trust_bundle_02_rsa.p7b", | ||
| clientCertFile: dirPath + "ca-02/client-rsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-02/client-rsa-a-key.pem", | ||
| cversion: "certz3", | ||
| bversion: "bundle3", | ||
| newTLScreds: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type ecdsa trustbundle with 2 CA configuration", | ||
| serverCertFile: dirPath + "ca-02/server-ecdsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-02/server-ecdsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-02/trust_bundle_02_ecdsa.p7b", | ||
| clientCertFile: dirPath + "ca-02/client-ecdsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-02/client-ecdsa-a-key.pem", | ||
| cversion: "certz4", | ||
| bversion: "bundle4", | ||
| newTLScreds: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type rsa trustbundle with 10CA configuration", | ||
| serverCertFile: dirPath + "ca-10/server-rsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-10/server-rsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-10/trust_bundle_10_rsa.p7b", | ||
| clientCertFile: dirPath + "ca-10/client-rsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-10/client-rsa-a-key.pem", | ||
| cversion: "certz5", | ||
| bversion: "bundle5", | ||
| newTLScreds: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type ecdsa trustbundle with 10CA configuration", | ||
| serverCertFile: dirPath + "ca-10/server-ecdsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-10/server-ecdsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-10/trust_bundle_10_ecdsa.p7b", | ||
| clientCertFile: dirPath + "ca-10/client-ecdsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-10/client-ecdsa-a-key.pem", | ||
| cversion: "certz6", | ||
| bversion: "bundle6", | ||
| newTLScreds: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type rsa trustbundle with 1000CA configuration", | ||
| serverCertFile: dirPath + "ca-1000/server-rsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-1000/server-rsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-1000/trust_bundle_1000_rsa.p7b", | ||
| clientCertFile: dirPath + "ca-1000/client-rsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-1000/client-rsa-a-key.pem", | ||
| cversion: "certz7", | ||
| bversion: "bundle7", | ||
| newTLScreds: true, | ||
| scale: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.1:Load the key-type ecdsa trustbundle with 1000CA configuration", | ||
| serverCertFile: dirPath + "ca-1000/server-ecdsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-1000/server-ecdsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-1000/trust_bundle_1000_ecdsa.p7b", | ||
| clientCertFile: dirPath + "ca-1000/client-ecdsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-1000/client-ecdsa-a-key.pem", | ||
| cversion: "certz8", | ||
| bversion: "bundle8", | ||
| newTLScreds: true, | ||
| scale: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.2:Load the rsa trust_bundle from ca-02 with mismatching key type rsa client certificate from ca-01", | ||
| serverCertFile: dirPath + "ca-02/server-rsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-02/server-rsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-02/trust_bundle_02_rsa.p7b", | ||
| clientCertFile: dirPath + "ca-01/client-rsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-01/client-rsa-a-key.pem", | ||
| mismatch: true, | ||
| cversion: "certz9", | ||
| bversion: "bundle9", | ||
| newTLScreds: true, | ||
| }, | ||
| { | ||
| desc: "Certz1.2:Load the ecdsa trust_bundle from ca-02 with mismatching key type ecdsa client certificate from ca-01", | ||
| serverCertFile: dirPath + "ca-02/server-ecdsa-a-cert.pem", | ||
| serverKeyFile: dirPath + "ca-02/server-ecdsa-a-key.pem", | ||
| trustBundleFile: dirPath + "ca-02/trust_bundle_02_ecdsa.p7b", | ||
| clientCertFile: dirPath + "ca-01/client-ecdsa-a-cert.pem", | ||
| clientKeyFile: dirPath + "ca-01/client-ecdsa-a-key.pem", | ||
| mismatch: true, | ||
| cversion: "certz10", | ||
| bversion: "bundle10", | ||
| newTLScreds: true, | ||
| }, | ||
| } | ||
| for _, tc := range cases { | ||
| t.Run(tc.desc, func(t *testing.T) { | ||
| t.Logf("STATUS:Starting test case: %s", tc.desc) | ||
| //Read the serverSAN (Subject Alternative Name) from the certificate used for TLS verification. | ||
| serverSAN := setup_service.ReadDecodeServerCertificate(t, tc.serverCertFile) | ||
| //Build serverCertEntity for the server certificate rotation. | ||
| serverCert := setup_service.CreateCertzChain(t, setup_service.CertificateChainRequest{ | ||
| RequestType: setup_service.EntityTypeCertificateChain, | ||
| ServerCertFile: tc.serverCertFile, | ||
| ServerKeyFile: tc.serverKeyFile}) | ||
| serverCertEntity := setup_service.CreateCertzEntity(t, setup_service.EntityTypeCertificateChain, &serverCert, tc.cversion) | ||
| //Create a new Cert Pool and add the certs from the trustbundle. | ||
| pkcs7certs, pkcs7data, err := setup_service.Loadpkcs7TrustBundle(tc.trustBundleFile) | ||
| if err != nil { | ||
| t.Fatalf("STATUS:failed to load trust bundle: %v", err) | ||
| } | ||
| newCaCert := x509.NewCertPool() | ||
| for _, c := range pkcs7certs { | ||
| newCaCert.AddCert(c) | ||
| } | ||
| //Build trustBundleEntity for the server certificate rotation. | ||
| trustBundleEntity := setup_service.CreateCertzEntity(t, setup_service.EntityTypeTrustBundle, string(pkcs7data), tc.bversion) | ||
| //Load Client certificate | ||
| newClientCert, err := tls.LoadX509KeyPair(tc.clientCertFile, tc.clientKeyFile) | ||
| if err != nil { | ||
| t.Fatalf("STATUS:Failed to load client cert: %v", err) | ||
| } | ||
| activeCertzClient := certzClient | ||
| activeGNMIClient := gnmiClient | ||
| if tc.newTLScreds { | ||
| t.Logf("STATUS:%s: Creating new TLS credentials for client connection.", tc.desc) | ||
| //Load the prior client keypair for new client TLS credentials. | ||
| prevClientCert, err := tls.LoadX509KeyPair(prevClientCertFile, prevClientKeyFile) | ||
| if err != nil { | ||
| t.Fatalf("STATUS:%s:Failed to load previous client cert: %v", tc.desc, err) | ||
| } | ||
| oldPkcs7certs, oldPkcs7data, err := setup_service.Loadpkcs7TrustBundle(prevTrustBundleFile) | ||
| if err != nil { | ||
| t.Fatalf("STATUS:%s:Failed to load previous trust bundle,data %v with %v", tc.desc, oldPkcs7data, err) | ||
| } | ||
| //Create a old set of Cert Pool and append the certs from previous trust bundle. | ||
| prevCaCert := x509.NewCertPool() | ||
| for _, c := range oldPkcs7certs { | ||
| prevCaCert.AddCert(c) | ||
| } | ||
| //Before rotation, validation of all services with existing certificates. | ||
| if result := setup_service.ServicesValidationCheck(t, prevCaCert, expectedResult, serverSAN, serverAddr, username, password, prevClientCert, tc.mismatch); !result { | ||
| t.Fatalf("STATUS:%s:service validation failed before rotate- got %v, want %v.", tc.desc, result, expectedResult) | ||
| } | ||
| //Retrieve the connection with previous TLS credentials for certz rotation. | ||
| conn := setup_service.CreateNewDialOption(t, prevClientCert, prevCaCert, serverSAN, username, password, serverAddr) | ||
| defer conn.Close() | ||
| activeCertzClient = certzpb.NewCertzClient(conn) | ||
| activeGNMIClient = gnmi.NewGNMIClient(conn) | ||
| } else { | ||
| t.Logf("STATUS:%s:Using existing TLS credentials for client connection in first iteration.", tc.desc) | ||
| } | ||
| //Initiate certz rotation. | ||
| t.Logf("STATUS:%s Initiating Certz rotation with server cert: %s and trust bundle: %s", tc.desc, tc.serverCertFile, tc.trustBundleFile) | ||
| if success := setup_service.CertzRotate(ctx, t, newCaCert, activeCertzClient, activeGNMIClient, newClientCert, dut, username, password, serverSAN, serverAddr, testProfile, tc.newTLScreds, tc.mismatch, tc.scale, &serverCertEntity, &trustBundleEntity); !success { | ||
| t.Fatalf("STATUS: %s:Certz rotation failed.", tc.desc) | ||
| } | ||
| t.Logf("STATUS:%s: Certz rotation completed!", tc.desc) | ||
| //Post rotate validation of all services. | ||
| t.Run("Verification of new connection after rotate ", func(t *testing.T) { | ||
| if result := setup_service.ServicesValidationCheck(t, newCaCert, expectedResult, serverSAN, serverAddr, username, password, newClientCert, tc.mismatch); !result { | ||
| t.Fatalf("STATUS:%s:service validation failed after rotate- got %v, want %v.", tc.desc, result, expectedResult) | ||
| } | ||
| t.Logf("STATUS:%s:service validation done!", tc.desc) | ||
| }) | ||
| //Archiving previous client cert/key and trustbundle. | ||
| prevClientCertFile = tc.clientCertFile | ||
| prevClientKeyFile = tc.clientKeyFile | ||
| prevTrustBundleFile = tc.trustBundleFile | ||
| }) | ||
| } | ||
| t.Logf("STATUS:Client certificates Test completed!") | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.