feat(bgp): Add RT-1.102 DUT eBGP L3VPN params.#5655
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature network test (FNT) to verify BGP L3VPN parameter support on the device under test. The changes focus on validating dual-stack eBGP session establishment within isolated VRFs and ensuring correct propagation of route distinguisher and route target attributes, while also confirming proper inter-tenant isolation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5655 / 183a880Virtual Devices
Hardware Devices
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new test plan RT-1.102 for validating eBGP session establishment and L3VPN attribute handling on a DUT within tenant VRFs for both IPv4 and IPv6. It adds a README.md, metadata.textproto, and registers the test in testregistry.textproto. The feedback suggests a minor correction in the README.md to remove trailing slashes from the OpenConfig telemetry paths for AFT entries to align with standard OpenConfig path syntax.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1. **MD5 authentication**: Added `/network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/config/auth-password` to the requirements and updated the customer eBGP peers in the Canonical OC. 2. **Graceful restart**: Added GR paths (`enabled`, `restart-time`) to requirements and configured them (120s) in the Canonical OC. Explicit validation steps (`RT-1.102.5`, `RT-1.102.6`) have been added. 3. **Maximum prefix limits**: Added `/network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/afi-safis/afi-safi/ipv4-unicast/prefix-limit/config/max-prefixes` and updated test steps (`RT-1.102.3`) to cover limit enforcement. 4. **Explicit Router IDs**: Configured explicit Router IDs for both the Default network instance and the tenant VRF (`VRF_100`) in the Canonical OC to ensure deterministic behavior. 5. **BFD**: Added to the **TODO** section for future expansion, as it requires dedicated test scenarios and validation. Regarding **Dynamic peering for iBGP listeners**: This functional test (`RT-1.102`) is focused on L3VPN parameter coverage and VRF isolation. Dynamic BGP listeners/neighbors are covered in depth in **RT-1.103** (see `bgp_dynamic_neighbors/README.md`). Keeping the core iBGP peers static in this scenario ensures focus on VRF behavior and avoids compounding complexity.
ram-mac
left a comment
ram-mac
left a comment
There was a problem hiding this comment.
@ccie57960
Looks good after the changes added to the Readme. Hence Approving it.
But there are CI/CD errors that needs to be fixed. Please address them
Updated the Canonical OpenConfig section with detailed interface configurations.
Removed redundant IPv4 and IPv6 subnet entries for Link 1 and Link 2 in the README.
Updated IPv4 and IPv6 subnet assignments for Link 1 and Link 2 to specify correct DUT and ATE addresses.
Added a TODO for BFD coverage in BGP sessions.
3 participants
No description provided.