gRIBI scale: Nokia re-encap into a single tunnel

[dracazacula]

Currently Nokia does not support yet repairing traffic through multiple backup tunnels; specifically multiple re-encap next-hops in a single next-hop-group are not supported.

The vendor has planned for the feature but in the meantime we need a workaround for the test.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the gRIBI scale testing logic to accommodate hardware-specific constraints regarding tunnel re-encapsulation. By adding a conditional check for Nokia devices, the test suite now correctly handles cases where multiple backup tunnels are not supported, preventing potential configuration errors during scale testing.

Highlights

• Vendor-specific logic: Introduced a helper function to detect if a device supports re-encapsulation into multiple backup tunnels.
• GRIBI configuration update: Modified the repair NHG generation logic to default to a single tunnel for Nokia devices, ensuring compatibility with current hardware limitations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5664 / 4e68837

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request introduces a helper function repairReencapIntoMultipleBackupTunnels to conditionally bypass configuring multiple backup tunnels for vendors that do not support it (specifically Nokia). The reviewer recommends refactoring this vendor-specific check to use a deviation from the deviations package instead of directly calling dut.Vendor(), which aligns with the repository's style guidelines for maintaining test abstraction and portability.