Skip to content

Adding new test for coverage of ipv6 dynamic NDP state transition#5666

Open
ram-mac wants to merge 1 commit into
openconfig:mainfrom
ram-mac:ipv6_dynamic_ndp
Open

Adding new test for coverage of ipv6 dynamic NDP state transition#5666
ram-mac wants to merge 1 commit into
openconfig:mainfrom
ram-mac:ipv6_dynamic_ndp

Conversation

@ram-mac

@ram-mac ram-mac commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

New test coverage to enhance ipv6 neighbor dynamic NDP state validation
TC1: Initial Neighbor Discovery Resolution (REACHABLE State): Verifies that initiating traffic resolves the neighbor and transitions the OpenConfig neighbor-state to REACHABLE.
TC2: Neighbor Inactivity and Transition to STALE: Verifies that stopping traffic correctly transitions the neighbor entry to STALE after the timeout.
TC3: Stale Neighbor Traffic Recovery: Resumes traffic to verify that sending data-plane traffic to a STALE neighbor correctly triggers NDP re-resolution, transitions the state back to REACHABLE, and ensures minimal packet loss during the probe.

@ram-mac ram-mac requested review from a team as code owners July 4, 2026 05:09
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test suite to validate IPv6 dynamic NDP state transitions on the device under test. The tests ensure that neighbor discovery correctly transitions through REACHABLE and STALE states based on traffic activity, verifying the robustness of the IPv6 neighbor management implementation.

Highlights

  • New Test Coverage: Added comprehensive test coverage for IPv6 dynamic Neighbor Discovery Protocol (NDP) state transitions, including REACHABLE, STALE, and recovery scenarios.
  • Documentation and Metadata: Included a detailed README.md outlining the test procedure and OpenConfig coverage, along with the necessary metadata.textproto for the new test suite.
  • Registry Update: Registered the new test case 'RT-5.16' in the global testregistry.textproto.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test plan and metadata for "RT-5.16: IPv6 Dynamic Neighbor Discovery (NDP) State Transitions" under feature/interface/ip/otg_tests/ipv6_neighbor_state_test/, along with its registration in testregistry.textproto. Feedback was provided to replace the placeholder value FFF under the "Minimum DUT Platform Requirement" section in the README with a valid requirement.

Comment thread feature/interface/ip/otg_tests/ipv6_neighbor_state_test/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants