Adding new test for coverage of ipv6 dynamic NDP state transition#5666
Adding new test for coverage of ipv6 dynamic NDP state transition#5666ram-mac wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test suite to validate IPv6 dynamic NDP state transitions on the device under test. The tests ensure that neighbor discovery correctly transitions through REACHABLE and STALE states based on traffic activity, verifying the robustness of the IPv6 neighbor management implementation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new test plan and metadata for "RT-5.16: IPv6 Dynamic Neighbor Discovery (NDP) State Transitions" under feature/interface/ip/otg_tests/ipv6_neighbor_state_test/, along with its registration in testregistry.textproto. Feedback was provided to replace the placeholder value FFF under the "Minimum DUT Platform Requirement" section in the README with a valid requirement.
New test coverage to enhance ipv6 neighbor dynamic NDP state validation
TC1: Initial Neighbor Discovery Resolution (REACHABLE State): Verifies that initiating traffic resolves the neighbor and transitions the OpenConfig neighbor-state to REACHABLE.
TC2: Neighbor Inactivity and Transition to STALE: Verifies that stopping traffic correctly transitions the neighbor entry to STALE after the timeout.
TC3: Stale Neighbor Traffic Recovery: Resumes traffic to verify that sending data-plane traffic to a STALE neighbor correctly triggers NDP re-resolution, transitions the state back to REACHABLE, and ensures minimal packet loss during the probe.