Skip to content

Add enhancement to the gnmi subscription#5667

Open
ram-mac wants to merge 2 commits into
openconfig:mainfrom
ram-mac:gnmi_subscribtion_modification
Open

Add enhancement to the gnmi subscription#5667
ram-mac wants to merge 2 commits into
openconfig:mainfrom
ram-mac:gnmi_subscribtion_modification

Conversation

@ram-mac

@ram-mac ram-mac commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Created a new test function TestParallelInterfaceSubscriptions in gnmi_subscriptionlist_test.go.
-This test retrieves two ports from the DUT, constructs port-specific paths using explicit port names, and launches parallel subscription streams in separate goroutines to assert successful receipt of sync_response markers concurrently.

@ram-mac ram-mac requested a review from a team as a code owner July 4, 2026 06:07
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case to validate the parallel subscription capabilities of the gNMI implementation. By launching concurrent subscription streams for multiple interfaces, the change ensures that the system correctly handles simultaneous requests and provides the expected synchronization responses.

Highlights

  • New Test Function: Added TestParallelInterfaceSubscriptions to verify concurrent gNMI subscription streams on multiple interfaces.
  • Documentation Update: Updated the README to include the procedure and requirements for testing parallel gNMI subscription requests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Jul 4, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5667 / a62149f

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-2: gnmi_subscriptionlist_test
f83df794 Log
Cisco 8000E status
gNMI-2: gnmi_subscriptionlist_test
f799515e Log
Cisco XRd status
gNMI-2: gnmi_subscriptionlist_test
8b526e49 Log
Juniper ncPTX status
gNMI-2: gnmi_subscriptionlist_test
c4023ba3 Log
Nokia SR Linux status
gNMI-2: gnmi_subscriptionlist_test
715b5475 Log
Openconfig Lemming status
gNMI-2: gnmi_subscriptionlist_test
7823d770 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-2: gnmi_subscriptionlist_test
Cisco 8808 status
gNMI-2: gnmi_subscriptionlist_test
Juniper PTX10008 status
gNMI-2: gnmi_subscriptionlist_test
Nokia 7250 IXR-10e status
gNMI-2: gnmi_subscriptionlist_test

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test plan in README.md to include a new test case (gNMI-2.3) for verifying parallel, concurrent gNMI subscription requests on multiple interfaces, along with a canonical OpenConfig JSON example. The review feedback recommends making the test plan language-agnostic by replacing the Go-specific term "goroutines" with "concurrent sessions" and correcting the JSON example to use a namespace-qualified identityref (iana-if-type:ethernetCsmacd) for the interface type.

Comment thread feature/gnmi/subscribe/tests/gnmi_subscriptionlist_test/README.md Outdated
Comment thread feature/gnmi/subscribe/tests/gnmi_subscriptionlist_test/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants