Add enhancement to the gnmi subscription#5667
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test case to validate the parallel subscription capabilities of the gNMI implementation. By launching concurrent subscription streams for multiple interfaces, the change ensures that the system correctly handles simultaneous requests and provides the expected synchronization responses. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5667 / a62149fVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the test plan in README.md to include a new test case (gNMI-2.3) for verifying parallel, concurrent gNMI subscription requests on multiple interfaces, along with a canonical OpenConfig JSON example. The review feedback recommends making the test plan language-agnostic by replacing the Go-specific term "goroutines" with "concurrent sessions" and correcting the JSON example to use a namespace-qualified identityref (iana-if-type:ethernetCsmacd) for the interface type.
Created a new test function TestParallelInterfaceSubscriptions in gnmi_subscriptionlist_test.go.
-This test retrieves two ports from the DUT, constructs port-specific paths using explicit port names, and launches parallel subscription streams in separate goroutines to assert successful receipt of sync_response markers concurrently.