Skip to content

Modify optics_power_and_bias_current_test to address coverage gaps#5668

Open
ram-mac wants to merge 4 commits into
openconfig:mainfrom
ram-mac:optics_power_and_bias_mod
Open

Modify optics_power_and_bias_current_test to address coverage gaps#5668
ram-mac wants to merge 4 commits into
openconfig:mainfrom
ram-mac:optics_power_and_bias_mod

Conversation

@ram-mac

@ram-mac ram-mac commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Modify optics_power_and_bias_current_test.go with below changes
-Sampling rate increased to 10s, monitoring window extended to 3 minutes, and checks added to verify telemetry stability (no -40 dBm/0 mA dips) when the interface is UP

@ram-mac ram-mac requested a review from a team as a code owner July 4, 2026 06:44
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the optics power and bias current test suite to improve detection of intermittent telemetry issues. By extending the monitoring duration and increasing the sampling frequency, the test now provides more robust validation of telemetry stability during steady-state operations.

Highlights

  • Test Coverage Enhancement: Added documentation for bug coverage related to intermittent telemetry dips on Cisco platforms.
  • Monitoring Parameters: Updated the test to use a 10-second sampling interval over a 3-minute monitoring window to better detect telemetry instability.
  • Stability Assertions: Implemented new checks to ensure that optics power does not drop to -40 dBm and laser bias current remains above 0 when the interface is UP.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the optics power and bias current test to document bug coverage for intermittent telemetry dips on Cisco platforms (b/433734226). The review feedback recommends replacing an internal Google short link with the public-facing Google Issue Tracker URL format to ensure accessibility for external contributors.

Comment thread feature/platform/tests/optics_power_and_bias_current_test/README.md Outdated
Comment thread feature/platform/tests/optics_power_and_bias_current_test/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants