Add packet trimming counters by sallylsy · Pull Request #1458 · openconfig/public

sallylsy · 2026-03-26T01:21:30Z

Change Scope

Add paths to support packet trimming counters.
This change is backwards compatible.

Platform Implementations

Implementation A: Sonic HLD.
Implementation B: Nvidia Supports.

Tree View

 module: openconfig-interfaces
   +--rw interfaces
      +--rw interface* [name]
         +--ro state
         |  +--ro counters
         |  |  +--ro in-octets?               oc-yang:counter64
         |  |  +--ro in-pkts?                 oc-yang:counter64
         |  |  +--ro in-unicast-pkts?         oc-yang:counter64
         |  |  +--ro in-broadcast-pkts?       oc-yang:counter64
         |  |  +--ro in-multicast-pkts?       oc-yang:counter64
         |  |  +--ro in-errors?               oc-yang:counter64
         |  |  +--ro in-discards?             oc-yang:counter64
         |  |  +--ro out-octets?              oc-yang:counter64
         |  |  +--ro out-pkts?                oc-yang:counter64
         |  |  +--ro out-unicast-pkts?        oc-yang:counter64
         |  |  +--ro out-broadcast-pkts?      oc-yang:counter64
         |  |  +--ro out-multicast-pkts?      oc-yang:counter64
         |  |  +--ro out-discards?            oc-yang:counter64
         |  |  +--ro out-errors?              oc-yang:counter64
         |  |  +--ro last-clear?              oc-types:timeticks64
         |  |  +--ro in-unknown-protos?       oc-yang:counter64
         |  |  +--ro in-fcs-errors?           oc-yang:counter64
         |  |  x--ro carrier-transitions?     oc-yang:counter64
         |  |  +--ro interface-transitions?   oc-yang:counter64
         |  |  +--ro link-transitions?        oc-yang:counter64
         |  |  +--ro resets?                  oc-yang:counter64
+        |  |  +--ro oc-qos:out-trim-pkts?           oc-yang:counter64
+        |  |  +--ro oc-qos:trim-pkts?               oc-yang:counter64
+        |  |  +--ro oc-qos:dropped-trim-pkts?       oc-yang:counter64
 module: openconfig-platform
   +--rw components
      +--rw component* [name]
         +--rw integrated-circuit
         |  +--ro oc-ppc:pipeline-counters
         |     +--ro oc-ppc:packet
         |     |  +--ro oc-ppc:interface-block
         |     |  |  +--ro oc-ppc:state
         |     |  |     +--ro oc-ppc:in-packets?    oc-yang:counter64
         |     |  |     +--ro oc-ppc:out-packets?   oc-yang:counter64
         |     |  |     +--ro oc-ppc:in-bytes?      oc-yang:counter64
         |     |  |     +--ro oc-ppc:out-bytes?     oc-yang:counter64
+        |     |  +--ro oc-ppc:trim
+        |     |     +--ro oc-ppc:state
+        |     |        +--ro oc-ppc:trim-pkts?       oc-yang:counter64
+        |     |        +--ro oc-ppc:out-trim-pkts?   oc-yang:counter64
         |     +--ro oc-ppc:drop
         |     |  +--ro oc-ppc:state
+        |     |  |  +--ro oc-ppc:trim-pkts?                     oc-yang:counter64
         |     |  |  +--ro oc-ppc:adverse-aggregate?             oc-yang:counter64
         |     |  |  +--ro oc-ppc:congestion-aggregate?          oc-yang:counter64
         |     |  |  +--ro oc-ppc:packet-processing-aggregate?   oc-yang:counter64
         |     |  |  +--ro oc-ppc:urpf-aggregate?                oc-yang:counter64
         |     |  |  +--ro oc-ppc:no-route?                      oc-yang:counter64
 module: openconfig-qos
   +--rw qos
      +--rw config
      +--ro state
      +--rw interfaces
      |  +--rw interface* [interface-id]
      |     +--rw output
      |        +--rw config
      |        |  +--rw buffer-allocation-profile?             -> ../../../../../buffer-allocation-profiles/buffer-allocation-profile/config/name
      |        |  +--rw multicast-buffer-allocation-profile?   -> ../../../../../buffer-allocation-profiles/buffer-allocation-profile/config/name
      |        |  +--rw unicast-buffer-allocation-profile?     -> ../../../../../buffer-allocation-profiles/buffer-allocation-profile/config/name
      |        +--ro state
      |        |  +--ro buffer-allocation-profile?             -> ../../../../../buffer-allocation-profiles/buffer-allocation-profile/config/name
      |        |  +--ro multicast-buffer-allocation-profile?   -> ../../../../../buffer-allocation-profiles/buffer-allocation-profile/config/name
      |        |  +--ro unicast-buffer-allocation-profile?     -> ../../../../../buffer-allocation-profiles/buffer-allocation-profile/config/name
      |        +--rw classifiers
      |        |  +--rw classifier* [type]
      |        |     +--rw type      -> ../config/type
      |        |     +--rw config
      |        |     |  +--rw name?   -> ../../../../../../../classifiers/classifier/config/name
      |        |     |  +--rw type?   enumeration
      |        |     +--ro state
      |        |     |  +--ro name?   -> ../../../../../../../classifiers/classifier/config/name
      |        |     |  +--ro type?   enumeration
      |        |     +--rw terms
      |        |        +--ro term* [id]
      |        |           +--ro id       -> ../state/id
      |        |           +--ro state
      |        |              +--ro id?                -> ../../../../../../../../../classifiers/classifier[name=current()/../../../../config/name]/terms/term/config/id
      |        |              +--ro matched-packets?   oc-yang:counter64
      |        |              +--ro matched-octets?    oc-yang:counter64
      |        +--rw queues
      |        |  +--rw queue* [name]
      |        |     +--rw name      -> ../config/name
      |        |     +--rw config
      |        |     |  +--rw name?                       string
      |        |     |  +--rw queue-management-profile?   -> ../../../../../../../queue-management-profiles/queue-management-profile/config/name
      |        |     +--ro state
      |        |        +--ro name?                       string
      |        |        +--ro queue-management-profile?   -> ../../../../../../../queue-management-profiles/queue-management-profile/config/name
      |        |        +--ro max-queue-len?              oc-yang:counter64
      |        |        +--ro avg-queue-len?              oc-yang:counter64
      |        |        +--ro transmit-pkts?              oc-yang:counter64
      |        |        +--ro transmit-octets?            oc-yang:counter64
      |        |        +--ro dropped-pkts?               oc-yang:counter64
      |        |        +--ro dropped-octets?             oc-yang:counter64
      |        |        +--ro ecn-marked-pkts?            oc-yang:counter64
      |        |        +--ro ecn-marked-octets?          oc-yang:counter64
      |        |        +--ro ecn-selected-pkts?          oc-yang:counter64
      |        |        +--ro ecn-selected-octets?        oc-yang:counter64
+     |        |        +--ro out-trim-pkts?              oc-yang:counter64
+     |        |        +--ro trim-pkts?                  oc-yang:counter64
+     |        |        +--ro dropped-trim-pkts?          oc-yang:counter64

gemini-code-assist · 2026-03-26T01:21:54Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances network observability by introducing a set of packet trimming counters across various OpenConfig YANG models. The changes provide detailed metrics on packets that undergo trimming, including those successfully transmitted and those dropped, at the interface, integrated circuit, and QoS queue levels. This update ensures backward compatibility while expanding the data model to support more granular monitoring of network device behavior related to packet processing.

Highlights

New Packet Trimming Counters: Introduced three new packet trimming counters: out-trim-pkts (packets trimmed and successfully transmitted), trim-pkts (total packets trimmed), and dropped-trim-pkts (packets trimmed but dropped).
Expanded Observability: These new counters are integrated into OpenConfig YANG models at multiple levels: interface, integrated circuit (switch-wide), and QoS output queue, providing comprehensive visibility into packet trimming operations.
YANG Module Updates: Updated openconfig-interfaces, openconfig-platform-integrated-circuit, openconfig-platform-pipeline-counters, and openconfig-qos-interfaces modules to incorporate the new counter definitions and augment existing data models.
QoS Grouping Refactoring: The qos-interface-queue-root-top grouping in openconfig-qos-interfaces was refactored into qos-interface-input-queue-root-top and qos-interface-output-queue-root-top to better differentiate input and output queue contexts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces new YANG definitions for packet trimming counters across various OpenConfig modules. It updates openconfig-interfaces, openconfig-platform-integrated-circuit, openconfig-platform-pipeline-counters, and openconfig-qos-interfaces to include these new counter types at port, switch, and queue levels, respectively. The review comments highlight several typos in the revision descriptions and suggest grammatical improvements for the descriptions of the new counter leaves.

ElodinLaarz · 2026-03-31T17:06:57Z

Discussed at OC Operators Meeting March 31, 2026:

Can we add information (maybe updating the descriptions for the existing packet counters) about how these trimmed packet counters interact with the existing discard / out packet counters?

sallylsy · 2026-04-01T00:34:34Z

Discussed at OC Operators Meeting March 31, 2026:

Can we add information (maybe updating the descriptions for the existing packet counters) about how these trimmed packet counters interact with the existing discard / out packet counters?

Updated the description for

/interfaces/interface/state/counters/out-discards

and

/qos/interfaces/interface/output/queues/queue/state/dropped-pkts

ElodinLaarz · 2026-04-02T18:44:59Z

/gcbrun

OpenConfigBot · 2026-04-02T18:46:43Z

No major YANG version changes in commit d3eb20a

ElodinLaarz · 2026-04-02T21:19:23Z

/gcbrun

ElodinLaarz · 2026-04-03T16:13:38Z

/gcbrun

ElodinLaarz · 2026-04-07T14:57:32Z

/gcbrun

ElodinLaarz · 2026-04-21T16:18:46Z

/gcbrun

ElodinLaarz

Discussed at the OC Operators Meeting April 21, 2026:

Left a couple comments on the leaf descriptions / expectations for how trimmed packets interact with the existing leaves.

ElodinLaarz · 2026-05-05T16:18:26Z

/gcbrun

dplore · 2026-05-06T19:23:48Z

/gcbrun

dplore · 2026-05-06T19:39:57Z

/gcbrun

ElodinLaarz · 2026-05-06T19:50:58Z

/gcbrun

ElodinLaarz · 2026-05-06T20:27:22Z

Can we get the unresolved comments addressed-- other than that, it looks good to me.

sallylsy · 2026-05-07T00:42:37Z

Can we get the unresolved comments addressed-- other than that, it looks good to me.

Resolved. Thanks

dplore · 2026-05-12T16:21:03Z

Reviewed in May 12, 2026 OC Operators call. Setting last call to May 19, 2026

dplore · 2026-05-15T16:13:56Z

/gcbrun

dplore

@sallylsy can you address comments from @schornig please?

dplore · 2026-05-29T00:55:09Z

/gcbrun

dplore · 2026-05-29T16:23:09Z

/gcbrun

dplore · 2026-05-29T20:05:10Z

Thanks for fixing the circular reference! That part looks good, but now I notice we should move
/components/component/integrated-circuit/pipeline-counters/packet/trim/state/dropped-trim-packets
to
/components/component/integrated-circuit/pipeline-counters/packet/drop/state/dropped-trim-packets

(following existing patterns like
/components/component/integrated-circuit/pipeline-counters/drop/state/urpf-aggregate
/components/component/integrated-circuit/pipeline-counters/drop/state/no-route)

Apologies for the late comment on this.

dplore · 2026-05-29T21:55:56Z

/gcbrun

sallylsy requested a review from a team as a code owner March 26, 2026 01:21

github-project-automation Bot added this to OC Operator Review Mar 26, 2026

gemini-code-assist Bot reviewed Mar 26, 2026

View reviewed changes

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 2464c3d to 9d626f4 Compare March 26, 2026 19:27

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 9d626f4 to 3c76ad8 Compare April 1, 2026 00:32

OpenConfigBot added the non-breaking label Apr 2, 2026

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 3c76ad8 to 1f3ef98 Compare April 2, 2026 18:53

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 1f3ef98 to a4229cc Compare April 2, 2026 21:31

ElodinLaarz moved this to Ready to discuss in OC Operator Review Apr 7, 2026

mholankar approved these changes Apr 15, 2026

View reviewed changes

ElodinLaarz requested changes Apr 21, 2026

View reviewed changes

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 8b42fcc to ded3478 Compare May 1, 2026 00:10

Add packet trimming counters

df15b7b

sallylsy force-pushed the pkt_trim_cnt_0325 branch from ded3478 to df15b7b Compare May 5, 2026 17:29

dplore approved these changes May 6, 2026

View reviewed changes

ElodinLaarz approved these changes May 6, 2026

View reviewed changes

Merge branch 'master' into pkt_trim_cnt_0325

ae35af8

Merge branch 'master' into pkt_trim_cnt_0325

14f908c

dplore moved this from Ready to discuss to last-call in OC Operator Review May 12, 2026

schornig reviewed May 13, 2026

View reviewed changes

Comment thread release/models/platform/openconfig-platform-integrated-circuit.yang Outdated

Comment thread release/models/platform/openconfig-platform-pipeline-counters.yang

Comment thread release/models/platform/openconfig-platform-integrated-circuit.yang Outdated

dplore reviewed May 19, 2026

View reviewed changes

Comment thread release/models/platform/openconfig-platform-integrated-circuit.yang Outdated

dplore reviewed May 19, 2026

View reviewed changes

Add packet trimming counters

ce77896

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 4cef0ad to ce77896 Compare May 28, 2026 21:45

Merge branch 'master' into pkt_trim_cnt_0325

6871816

dplore reviewed May 29, 2026

View reviewed changes

Comment thread release/models/interfaces/openconfig-interfaces.yang Outdated

sallylsy force-pushed the pkt_trim_cnt_0325 branch from a0e723a to 32e0b4b Compare May 29, 2026 01:32

Add packet trimming counters

d3eb20a

sallylsy force-pushed the pkt_trim_cnt_0325 branch from 32e0b4b to d3eb20a Compare May 29, 2026 21:40

dplore merged commit e32c9c8 into openconfig:master May 29, 2026
19 checks passed

Conversation

sallylsy commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Scope

Platform Implementations

Tree View

Uh oh!

gemini-code-assist Bot commented Mar 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ElodinLaarz commented Mar 31, 2026

Uh oh!

sallylsy commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ElodinLaarz commented Apr 2, 2026

Uh oh!

OpenConfigBot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ElodinLaarz commented Apr 2, 2026

Uh oh!

ElodinLaarz commented Apr 3, 2026

Uh oh!

ElodinLaarz commented Apr 7, 2026

Uh oh!

ElodinLaarz commented Apr 21, 2026

Uh oh!

ElodinLaarz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ElodinLaarz commented May 5, 2026

Uh oh!

dplore commented May 6, 2026

Uh oh!

dplore commented May 6, 2026

Uh oh!

ElodinLaarz commented May 6, 2026

Uh oh!

ElodinLaarz commented May 6, 2026

Uh oh!

sallylsy commented May 7, 2026

Uh oh!

dplore commented May 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dplore commented May 15, 2026

Uh oh!

Uh oh!

dplore left a comment

Choose a reason for hiding this comment

Uh oh!

dplore commented May 29, 2026

Uh oh!

Uh oh!

dplore commented May 29, 2026

Uh oh!

dplore commented May 29, 2026

Uh oh!

dplore commented May 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

sallylsy commented Mar 26, 2026 •

edited

Loading

sallylsy commented Apr 1, 2026 •

edited

Loading

OpenConfigBot commented Apr 2, 2026 •

edited

Loading