Skip to content

Remove log that is always generated for annotation fields. #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robshakir merged 2 commits into from
Apr 22, 2022
Merged

Remove log that is always generated for annotation fields. #652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7492798
Remove log that is always generated for annotation fields.
robshakir Apr 22, 2022
268b94d
Remove import of log library.
robshakir Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ytypes/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"reflect"
"strings"

log "github.com/golang/glog"
"github.com/kylelemons/godebug/pretty"
"github.com/openconfig/goyang/pkg/yang"
"github.com/openconfig/ygot/util"
Expand Down Expand Up @@ -158,7 +157,6 @@ func unmarshalStruct(schema *yang.Entry, parent interface{}, jsonTree map[string
// Skip annotation fields since they do not have a schema.
// TODO(robjs): Implement unmarshalling annotations.
if util.IsYgotAnnotation(ft) {
log.Infof("ignoring annotation field %s during unmarshalling, unsupported", ft.Name)
// We need to find the paths that we should have unmarshalled here to avoid
// throwing errors to users whilst there is a TODO above.
paths, err := pathTagFromField(ft)
Expand Down