Skip to content

Release v1.2.1#4500

Merged
cyphar merged 2 commits into
opencontainers:release-1.2from
rata:rata/release-1.2.1
Nov 1, 2024
Merged

Release v1.2.1#4500
cyphar merged 2 commits into
opencontainers:release-1.2from
rata:rata/release-1.2.1

Conversation

@rata

@rata rata commented Nov 1, 2024

Copy link
Copy Markdown
Member

I propose to release 1.2.1 early next week TODAY (see comment asking for it here: #4500 (review)). containerd needs the fixes here to properly update to the 1.2.x branch.


[1.2.1] - 2024-11-05

No existe una escuela que enseñe a vivir.

Fixed

Changed

@rata

rata commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

Grrr, codespell is failing because it wants to correct spanish, that is written properly -.-. Changed it to another phrase now.

@rata rata force-pushed the rata/release-1.2.1 branch from ceb3929 to 536a486 Compare November 1, 2024 16:43
@rata rata changed the title Release 1.2.1 Release v1.2.1 Nov 1, 2024
@rata rata force-pushed the rata/release-1.2.1 branch 2 times, most recently from cc235d6 to fb01b7a Compare November 1, 2024 17:04
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@kolyshkin kolyshkin added this to the 1.2.1 milestone Nov 1, 2024
Comment thread CHANGELOG.md Outdated
@rata rata force-pushed the rata/release-1.2.1 branch 2 times, most recently from 0db3570 to 56053ab Compare November 1, 2024 18:07
@rata rata requested a review from kolyshkin November 1, 2024 18:08
@rata rata force-pushed the rata/release-1.2.1 branch from 56053ab to 208b422 Compare November 1, 2024 18:10
@rata

rata commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

Updated the release date for TODAY, as @AkihiroSuda asked

@rata

rata commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

Also, please feel free to push to this branch if you want to release today (maintainers can push). It's quite late here, I won't be online much longer.

@cyphar cyphar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll prep the release.

@cyphar

cyphar commented Nov 1, 2024

Copy link
Copy Markdown
Member

You forgot to update VERSION in the release commit. Pushing a fix...

rata added 2 commits November 2, 2024 08:58
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
@cyphar cyphar force-pushed the rata/release-1.2.1 branch from 827c909 to 5fc3558 Compare November 1, 2024 21:59
@cyphar cyphar merged commit 7a8738e into opencontainers:release-1.2 Nov 1, 2024
@cyphar

cyphar commented Nov 1, 2024

Copy link
Copy Markdown
Member

https://github.com/opencontainers/runc/releases/tag/v1.2.1

@h-vetinari

Copy link
Copy Markdown

Congratulations on the release! Just two comments from reading the release notes

Fixed

  • Became root after [...]

The release notes don't have the "Fixed" header, and so the sentence starting with "Became root" is pretty hard to make sense of.

Also, the current release notes say (my emphasis)

In addition, runc-dmz (added in 1.2.0) has been removed entirely. This was opt-out (due to the many limitations it had)

which should probably say "opt-in", c.f. the following from the OP

Note that runc-dmz was only available only in the 1.2.0 release and required to set an environment variable to opt-in.

@cyphar

cyphar commented Nov 4, 2024

Copy link
Copy Markdown
Member

@h-vetinari Fixed. Turns out I can't proofread properly late at night... 😅

@rata rata deleted the rata/release-1.2.1 branch November 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants