fix(codex-fleet-demo): guard attach behind TTY check, drop exec#168
Merged
Conversation
up.sh ended with 'exec tmux attach' which replaces the calling shell with tmux. When the script is launched without a controlling terminal (kitty launcher, command picker, non-interactive shell, etc.), the attach aborts with 'open terminal failed: not a terminal' and the parent process is left in a broken state -- observed to lock up the kitty session selector that spawned up.sh. Guard the attach behind '[[ -t 0 && -t 1 ]]' and drop the 'exec' so the shell returns cleanly whether or not the attach actually happens. When no TTY is present, print the manual attach command and exit 0 normally. Tear-down + re-up is the recovery path if you hit this in the wild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
`scripts/codex-fleet/demo/up.sh` ended with:
```bash
exec tmux -L "$SOCKET" attach -t "$SESSION"
```
`exec` replaces the calling shell with tmux. When up.sh is launched without a controlling terminal — kitty launcher, command picker, non-interactive shell, Claude Code's bash tool, etc. — the attach aborts with "open terminal failed: not a terminal" and the parent process is left in a broken state.
Observed: locks up the kitty session selector that spawned up.sh.
Fix
Test plan