Skip to content

fix(codex-fleet-demo): guard attach behind TTY check, drop exec #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagyVikt merged 1 commit into from
May 16, 2026
Merged

fix(codex-fleet-demo): guard attach behind TTY check, drop exec #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scripts/codex-fleet/demo/up.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,16 @@ echo "demo up. session=$SESSION socket=$SOCKET plan=$PLAN_SLUG"
echo "attach: tmux -L $SOCKET attach -t $SESSION"
echo "tear down: bash scripts/codex-fleet/demo/down.sh"

# Attach only when stdin + stdout are real TTYs. Without that, `exec tmux
# attach` aborts with "open terminal failed: not a terminal" and strands the
# parent — observed to lock up the kitty launcher / session picker that
# spawned up.sh. Drop `exec` so the shell returns cleanly even if tmux's
# attach fails for some other reason. Print the attach command when we skip.
if [[ "$attach" -eq 1 ]]; then
exec tmux -L "$SOCKET" attach -t "$SESSION"
if [[ -t 0 && -t 1 ]]; then
tmux -L "$SOCKET" attach -t "$SESSION"
else
echo "demo: no TTY available, skipping auto-attach" >&2
echo " run from a terminal: tmux -L $SOCKET attach -t $SESSION" >&2
fi
fi