Skip to content

Commit 5acb5c8

Browse files
committed
Keep Rust formatting checks aligned with the workspace manifest
Constraint: rs/Cargo.toml is a virtual workspace manifest, so cargo fmt --manifest-path rs/Cargo.toml --check fails before rustfmt reaches member crates. Rejected: formatting individual crate manifests | duplicates workspace membership and lets future crates escape CI. Confidence: high Scope-risk: narrow Directive: Keep the workflow, AGENTS.md, and PR template cargo fmt command in sync. Tested: git diff --check; bash AGENTS-release-check.sh; npm_config_cache=/tmp/npm-cache npx --yes markdown-link-check CHANGELOG.md --config .github/markdown-link-check-config.json -q; GitHub run 26217931032 showed markdown link-check success and cargo fmt failed with Failed to find targets. Not-tested: Local cargo fmt/clippy/tests; cargo is not installed in this environment.
1 parent 7d10ec2 commit 5acb5c8

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ See AGENTS.md for the full contributor + release workflow.
1919

2020
- [ ] Bash syntax + shellcheck pass through the `Lint` workflow
2121
- [ ] `cargo build --release --locked --manifest-path rs/Cargo.toml` passes (if any Rust changed)
22-
- [ ] `cargo fmt --manifest-path rs/Cargo.toml --check` passes (if any Rust changed)
22+
- [ ] `cargo fmt --manifest-path rs/Cargo.toml --all --check` passes (if any Rust changed)
2323
- [ ] `cargo clippy --release --locked --manifest-path rs/Cargo.toml -- -D warnings` passes (if any Rust changed)
2424
- [ ] `flashpaste-doctor` runs clean against the changes
2525
- [ ] If this is a `vX.Y` bump: tag pushed in the same turn (see [AGENTS.md](../AGENTS.md))

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
${{ runner.os }}-cargo-
9595
9696
- name: cargo fmt
97-
run: cargo fmt --manifest-path rs/Cargo.toml --check
97+
run: cargo fmt --manifest-path rs/Cargo.toml --all --check
9898

9999
- name: cargo clippy
100100
run: cargo clippy --release --locked --manifest-path rs/Cargo.toml -- -D warnings

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ bash -n bin/*.sh install.sh bootstrap.sh
126126

127127
# Rust workspace
128128
cargo build --release --manifest-path rs/Cargo.toml
129-
cargo fmt --manifest-path rs/Cargo.toml --check
129+
cargo fmt --manifest-path rs/Cargo.toml --all --check
130130
cargo clippy --release --manifest-path rs/Cargo.toml -- -D warnings
131131

132132
# Doctor

0 commit comments

Comments
 (0)