Purge stale Active Agents SCM installs (#420)

Older lowercase VS Code companion installs kept registering the removed Active Agents Commit Source Control provider even after the repo extension stopped creating it. The installer now deletes retired lowercase install IDs before refreshing the current Recodee companion copies, so already-open windows cannot keep loading that stale provider path after reload.

Constraint: VS Code may keep multiple local extension IDs under ~/.vscode/extensions and load stale publisher/name variants.

Rejected: Re-add a runtime Source Control hide shim | the current extension no longer creates a SourceControl object, so stale installed copies were the cause.

Confidence: high

Scope-risk: narrow

Directive: Keep retired extension ID cleanup when publisher/name casing changes; stale local install folders can survive normal compatibility refreshes.

Tested: node --test test/vscode-active-agents-session-state.test.js

Tested: diff -u scripts/install-vscode-active-agents-extension.js templates/scripts/install-vscode-active-agents-extension.js

Tested: node scripts/install-vscode-active-agents-extension.js removed 20 retired local install paths

Not-tested: node --test test/metadata.test.js remains red on unrelated README release-note/version expectations and existing Active Agents extension/template drift

Co-authored-by: NagyVikt <nagy.viktordp@gmail.com>

Author: NagyVikt

openspec/changes/agent-codex-remove-stale-active-agents-scm-provider-2026-04-24-17-44/notes.md

@@ -0,0 +1,19 @@
+# Remove stale Active Agents SCM providers
+
+## Intent
+
+Prevent old locally installed `recodeee.gitguardex-active-agents*` companion copies from continuing to register the removed `Active Agents Commit` Source Control providers.
+
+## Scope
+
+- Update the VS Code companion installer to delete retired extension IDs before installing the current `Recodee.gitguardex-active-agents` copy.
+- Keep `scripts/` and `templates/scripts/` installer copies in sync.
+- Extend the focused Active Agents extension test to cover retired install cleanup.
+
+## Verification
+
+- Passed: `node --test test/vscode-active-agents-session-state.test.js` (`55/55`).
+- Passed: `node scripts/install-vscode-active-agents-extension.js` removed 20 retired lowercase local install paths.
+- Passed: no remaining `recodeee.gitguardex-active-agents*` folders under `/home/deadpool/.vscode/extensions`.
+- Passed: no `createSourceControl` or `Active Agents Commit` matches in current installed `Recodee.gitguardex-active-agents` copies checked.
+- Baseline red: `node --test test/metadata.test.js` still fails unrelated README release-note/version expectations and pre-existing `vscode/guardex-active-agents/extension.js` template drift.

scripts/install-vscode-active-agents-extension.js

@@ -5,6 +5,9 @@ const os = require('node:os');
 const path = require('node:path');
 
 const PATCH_COMPATIBILITY_WINDOW = 20;
+const RETIRED_EXTENSION_IDS = [
+  'recodeee.gitguardex-active-agents',
+];
 
 function parseOptions(argv) {
   const options = {};
@@ -65,6 +68,12 @@ function buildInstallTargets(extensionId, version, extensionsDir) {
   return targets;
 }
 
+function isRetiredExtensionInstall(entryName, currentExtensionId) {
+  return RETIRED_EXTENSION_IDS
+    .filter((extensionId) => extensionId !== currentExtensionId)
+    .some((extensionId) => entryName === extensionId || entryName.startsWith(`${extensionId}-`));
+}
+
 function main() {
   const repoRoot = path.resolve(__dirname, '..');
   const options = parseOptions(process.argv.slice(2));
@@ -82,11 +91,17 @@ function main() {
   const targetDirs = buildInstallTargets(extensionId, manifest.version, extensionsDir);
   const canonicalTargetDir = targetDirs[0];
   const keepDirNames = new Set(targetDirs.map((targetDir) => path.basename(targetDir)));
+  let retiredInstallCount = 0;
 
   for (const entry of fs.readdirSync(extensionsDir, { withFileTypes: true })) {
     if (!entry.isDirectory()) {
       continue;
     }
+    if (isRetiredExtensionInstall(entry.name, extensionId)) {
+      removeIfExists(path.join(extensionsDir, entry.name));
+      retiredInstallCount += 1;
+      continue;
+    }
     if (keepDirNames.has(entry.name)) {
       continue;
     }
@@ -107,6 +122,7 @@ function main() {
   process.stdout.write(
     `[guardex-active-agents] Installed ${extensionId}@${manifest.version} to ${canonicalTargetDir}\n` +
       `[guardex-active-agents] Refreshed ${targetDirs.length - 1} recent patch compatibility path(s) for already-open windows.\n` +
+      `[guardex-active-agents] Removed ${retiredInstallCount} retired extension install path(s).\n` +
       '[guardex-active-agents] Reload each already-open VS Code window to activate the newest Source Control companion.\n',
   );
 }

templates/scripts/install-vscode-active-agents-extension.js

@@ -5,6 +5,9 @@ const os = require('node:os');
 const path = require('node:path');
 
 const PATCH_COMPATIBILITY_WINDOW = 20;
+const RETIRED_EXTENSION_IDS = [
+  'recodeee.gitguardex-active-agents',
+];
 
 function parseOptions(argv) {
   const options = {};
@@ -65,6 +68,12 @@ function buildInstallTargets(extensionId, version, extensionsDir) {
   return targets;
 }
 
+function isRetiredExtensionInstall(entryName, currentExtensionId) {
+  return RETIRED_EXTENSION_IDS
+    .filter((extensionId) => extensionId !== currentExtensionId)
+    .some((extensionId) => entryName === extensionId || entryName.startsWith(`${extensionId}-`));
+}
+
 function main() {
   const repoRoot = path.resolve(__dirname, '..');
   const options = parseOptions(process.argv.slice(2));
@@ -82,11 +91,17 @@ function main() {
   const targetDirs = buildInstallTargets(extensionId, manifest.version, extensionsDir);
   const canonicalTargetDir = targetDirs[0];
   const keepDirNames = new Set(targetDirs.map((targetDir) => path.basename(targetDir)));
+  let retiredInstallCount = 0;
 
   for (const entry of fs.readdirSync(extensionsDir, { withFileTypes: true })) {
     if (!entry.isDirectory()) {
       continue;
     }
+    if (isRetiredExtensionInstall(entry.name, extensionId)) {
+      removeIfExists(path.join(extensionsDir, entry.name));
+      retiredInstallCount += 1;
+      continue;
+    }
     if (keepDirNames.has(entry.name)) {
       continue;
     }
@@ -107,6 +122,7 @@ function main() {
   process.stdout.write(
     `[guardex-active-agents] Installed ${extensionId}@${manifest.version} to ${canonicalTargetDir}\n` +
       `[guardex-active-agents] Refreshed ${targetDirs.length - 1} recent patch compatibility path(s) for already-open windows.\n` +
+      `[guardex-active-agents] Removed ${retiredInstallCount} retired extension install path(s).\n` +
       '[guardex-active-agents] Reload each already-open VS Code window to activate the newest Source Control companion.\n',
   );
 }

test/vscode-active-agents-session-state.test.js

@@ -1217,11 +1217,17 @@ test('install-vscode-active-agents-extension installs the current extension into
     ? path.join(tempExtensionsDir, `${extensionId}-${major}.${minor}.${patch - 1}`)
     : currentVersionDir;
   const farLegacyDir = path.join(tempExtensionsDir, `${extensionId}-99.99.99`);
+  const retiredLegacyDir = path.join(tempExtensionsDir, 'recodeee.gitguardex-active-agents');
+  const retiredLegacyVersionDir = path.join(tempExtensionsDir, 'recodeee.gitguardex-active-agents-0.0.18');
 
   fs.mkdirSync(recentCompatDir, { recursive: true });
   fs.writeFileSync(path.join(recentCompatDir, 'stale.txt'), 'old', 'utf8');
   fs.mkdirSync(farLegacyDir, { recursive: true });
   fs.writeFileSync(path.join(farLegacyDir, 'stale.txt'), 'old', 'utf8');
+  fs.mkdirSync(retiredLegacyDir, { recursive: true });
+  fs.writeFileSync(path.join(retiredLegacyDir, 'extension.js'), 'vscode.scm.createSourceControl();\n', 'utf8');
+  fs.mkdirSync(retiredLegacyVersionDir, { recursive: true });
+  fs.writeFileSync(path.join(retiredLegacyVersionDir, 'extension.js'), 'vscode.scm.createSourceControl();\n', 'utf8');
 
   const result = runNode(installScript, ['--extensions-dir', tempExtensionsDir], {
     cwd: repoRoot,
@@ -1244,8 +1250,11 @@ test('install-vscode-active-agents-extension installs the current extension into
   assert.equal(fs.existsSync(path.join(recentCompatDir, 'package.json')), true);
   assert.equal(fs.existsSync(path.join(recentCompatDir, 'stale.txt')), false);
   assert.equal(fs.existsSync(farLegacyDir), false);
+  assert.equal(fs.existsSync(retiredLegacyDir), false);
+  assert.equal(fs.existsSync(retiredLegacyVersionDir), false);
   assert.match(result.stdout, new RegExp(`Installed ${extensionId}@${manifest.version} to ${canonicalDir.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}`));
   assert.match(result.stdout, /Refreshed \d+ recent patch compatibility path\(s\)/);
+  assert.match(result.stdout, /Removed 2 retired extension install path\(s\)/);
   assert.match(result.stdout, /Reload each already-open VS Code window/);
 });