feat: install inference.opendatahub.io CRDs in E2E infra + read RBAC#291
feat: install inference.opendatahub.io CRDs in E2E infra + read RBAC#291yossiovadia wants to merge 1 commit into
Conversation
- setup-kind.sh: install inference CRDs from config/crd/bases/ - entrypoint.sh: install inference CRDs in E2E container - Dockerfile.e2e: embed CRD files in test image - RBAC: add inference.opendatahub.io read-only (get/list/watch) Without these, the store reconcilers fail because the CRDs are not installed and the ServiceAccount lacks watch permissions.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yossiovadia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@yossiovadia: The following test has Succeeded: OCI Artifact Browser URLInspecting Test Artifacts ManuallyTo inspect your test artifacts manually, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:ai-gateway-group-test-jr9nk |
Summary
Installs
inference.opendatahub.ioCRDs and adds read-only RBAC so the store reconcilers (from #285, #286) can watch ExternalProvider and ExternalModel resources.4 files, 22 lines.
What this does
setup-kind.sh— install inference CRDs fromconfig/crd/bases/entrypoint.sh— install inference CRDs in E2E test containerDockerfile.e2e— embed CRD files in test imagerbac.yaml— addinference.opendatahub.ioget/list/watch for externalproviders and externalmodelsWhy needed
Without this, the store reconcilers crash in CI:
Risk analysis
cc @nirrozenbaum