Skip to content

feat: install inference.opendatahub.io CRDs in E2E infra + read RBAC#291

Open
yossiovadia wants to merge 1 commit into
opendatahub-io:mainfrom
yossiovadia:feat/e2e-inference-crds
Open

feat: install inference.opendatahub.io CRDs in E2E infra + read RBAC#291
yossiovadia wants to merge 1 commit into
opendatahub-io:mainfrom
yossiovadia:feat/e2e-inference-crds

Conversation

@yossiovadia
Copy link
Copy Markdown
Contributor

Summary

Installs inference.opendatahub.io CRDs and adds read-only RBAC so the store reconcilers (from #285, #286) can watch ExternalProvider and ExternalModel resources.

4 files, 22 lines.

What this does

  • setup-kind.sh — install inference CRDs from config/crd/bases/
  • entrypoint.sh — install inference CRDs in E2E test container
  • Dockerfile.e2e — embed CRD files in test image
  • rbac.yaml — add inference.opendatahub.io get/list/watch for externalproviders and externalmodels

Why needed

Without this, the store reconcilers crash in CI:

"if kind is a CRD, it should be installed before calling Start"
"no matches for kind ExternalProvider in version inference.opendatahub.io/v1alpha1"

Risk analysis

  • Risk rating: 1
  • Why: Only adds CRD installation and read-only RBAC. No code changes.

cc @nirrozenbaum

- setup-kind.sh: install inference CRDs from config/crd/bases/
- entrypoint.sh: install inference CRDs in E2E container
- Dockerfile.e2e: embed CRD files in test image
- RBAC: add inference.opendatahub.io read-only (get/list/watch)

Without these, the store reconcilers fail because the CRDs are not
installed and the ServiceAccount lacks watch permissions.
@openshift-ci openshift-ci Bot requested review from jland-redhat and nerdalert May 19, 2026 14:24
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yossiovadia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@yossiovadia has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 9 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 22b7414a-bf6b-4c9d-9457-d2c67a10e47f

📥 Commits

Reviewing files that changed from the base of the PR and between 9917fb4 and 4cd4069.

📒 Files selected for processing (4)
  • Dockerfile.e2e
  • deploy/payload-processing/templates/rbac.yaml
  • test/e2e/scripts/entrypoint.sh
  • test/e2e/scripts/setup-kind.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 19, 2026
@rhods-ci-bot
Copy link
Copy Markdown

@yossiovadia: The following test has Succeeded:

OCI Artifact Browser URL

View in Artifact Browser

Inspecting Test Artifacts Manually

To inspect your test artifacts manually, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:ai-gateway-group-test-jr9nk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants