fix: use oc CLI instead of kubectl in E2E container#294
Conversation
Replace kubectl with oc in the E2E Dockerfile and entrypoint script for OpenShift compatibility. The oc tarball also includes kubectl, so both are available. Go test helpers use KUBECTL_BIN env var (default: oc) for local override. setup-kind.sh is unchanged — it targets Kind clusters where kubectl is the correct tool.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yossiovadia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
github-actions
Bot
added
the
size/S
The GitHub Actions runner has kubectl but not oc. Default to kubectl in Go tests; the E2E container entrypoint uses oc directly.
|
@yossiovadia: The following test has Succeeded: OCI Artifact Browser URLInspecting Test Artifacts ManuallyTo inspect your test artifacts manually, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:ai-gateway-group-test-nnxhx |
2 participants
Summary
kubectlwithocin the E2E Dockerfile and entrypoint script for OpenShift/Konflux compatibilityocfrom Red Hat mirror (stable-4.17channel) — the tarball includes bothocandkubectlKUBECTL_BINenv var (default:oc) so local runs can override withkubectlsetup-kind.shis unchanged — it targets Kind clusters wherekubectlis correctPer DevTestOps team request to use
ocin E2E test containers.Test plan
go vet ./test/e2e/— cleanmake lint— 0 issuesocdownload (CI)oc(CI)