chore: add NOTICE file to align with opendataloader-project#9
chore: add NOTICE file to align with opendataloader-project#9hyunhee-jo wants to merge 1 commit into
Conversation
Objective: Downstream users redistributing the opendataloader-project family (pdf engine + llamaindex reader) face inconsistent NOTICE expectations. The upstream `opendataloader-pdf` ships a NOTICE file (Apache-2.0 § 4(d) attribution + third-party pointer), but `opendataloader-pdf-llamaindex` did not, leaving redistributors unsure which copyright/notices to carry forward. Approach: Add a NOTICE file matching the upstream convention — same Apache-2.0 boilerplate, retitled "LlamaIndex OpenDataLoader PDF", pointing to this repo's own URL. This repo does not yet have a THIRD_PARTY/ folder, so the third-party section points to pyproject.toml + PyPI package metadata and notes the folder may be added later. NOTICE is not a strict Apache-2.0 requirement, but adding it keeps the family consistent and gives downstream redistributors a single, predictable attribution source. Evidence: Metadata-only change; no runtime behavior. Verified via: | Scenario | Expected | Actual | |-----------------------------------------|-----------------------------------|-----------------------------------------| | NOTICE present at repo root | yes | yes | | NOTICE first line | "LlamaIndex OpenDataLoader PDF" | "LlamaIndex OpenDataLoader PDF" | | Apache-2.0 boilerplate | matches upstream pdf NOTICE | matches (same wording, retitled) | | Third-party section honest about state | yes | yes (points to pyproject.toml + PyPI) | | LICENSE / pyproject license unchanged | Apache-2.0 (unchanged) | Apache-2.0 (unchanged) |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 48 minutes and 17 seconds.Comment |
1 participant
Objective
Downstream users redistributing the
opendataloader-projectfamily(pdf engine + llamaindex reader + langchain integration + bench) face
inconsistent NOTICE expectations. The upstream
opendataloader-pdfships a
NOTICEfile (Apache-2.0 § 4(d) attribution + third-partypointer), but this repo did not — leaving downstream redistributors
unsure which copyright/notices to carry forward when they ship
pdf + llamaindextogether.Approach
Add a
NOTICEfile matching the upstreamopendataloader-pdfconvention:
This repo does not yet have a
THIRD_PARTY/folder (unlikepdfandlangchain), so the third-party section honestly points topyproject.toml+ PyPI package metadata and notes the folder may beadded later.
NOTICEis not a strict Apache-2.0 requirement (§ 4(d) only obligatespreservation if a NOTICE exists), but adding it keeps the family
consistent and gives downstream redistributors a single, predictable
attribution source.
Evidence
Metadata-only change; no runtime behavior. Verified via file inspection:
NOTICEpresent at repo rootLlamaIndex OpenDataLoader PDFLlamaIndex OpenDataLoader PDFpyproject.toml+ PyPI)LICENSE/pyprojectlicenseCompanion PRs aligning the rest of the family:
opendataloader-benchMIT → Apache-2.0 + NOTICE: chore: relicense from MIT to Apache-2.0 to match opendataloader-project opendataloader-bench#19langchain-opendataloader-pdfNOTICE: chore: add NOTICE file to align with opendataloader-project langchain-opendataloader-pdf#24Follow-up (out of scope)
Adding a
THIRD_PARTY/folder (consolidatedTHIRD_PARTY_LICENSES.md/THIRD_PARTY_NOTICES.md/licenses/) to match the rest of the familyis a separate task and can be tracked in a follow-up issue.