Commit 753434b
fix: remove fallback 0 for missing thresholds in step summary
Problem: thresholds.get(key, 0) silently treated missing threshold keys
as 0, causing the step summary to show a green check even when the
threshold config was incomplete.
Solution: skip metrics with missing thresholds instead of defaulting to 0.
Also apply regression_tolerance from thresholds.json and use a loop to
reduce duplication across score metrics.
Verification: YAML valid. Companion PR opendataloader-bench#9 updates
check_regression() with matching tolerance logic.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent f3ab80f commit 753434b
1 file changed
Lines changed: 17 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
149 | 138 | | |
150 | 139 | | |
151 | 140 | | |
| |||
155 | 144 | | |
156 | 145 | | |
157 | 146 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
162 | 152 | | |
163 | 153 | | |
164 | 154 | | |
| |||
0 commit comments