cleanup: remove dead exception-handling paths from closePdfResources (#472)

Both PDDocument.close() (verapdf) and StaticLayoutContainers
.closeContrastRatioConsumer() swallow exceptions internally and have no
throws clause. The accumulator pattern in closePdfResources() (capture
into closeFailure, addSuppressed, conditional re-throw) and the matching
try/catch in processFileWithResult's finally block were dead code in
practice — neither path could fire under any of the currently-imported
verapdf versions.

Route both close calls through the existing clearCleanupStep helper so
they share the same per-step isolation as the static-container resets.
The method now declares no throws and the caller's finally block
collapses to a single line.

Behaviorally equivalent: cleanup is still always invoked, per-step
isolation still prevents one failure from aborting the rest, processing
exceptions still surface unchanged. Verified locally — file descriptor
released after processFile returns (lsof shows neither the input PDF nor
verapdf's temp PDF), 566 core tests pass.

Closes #470

Author: bundolee

java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.java

@@ -75,28 +75,15 @@ public class DocumentProcessor {
      * - Clears static containers to remove lingering references
      * Should always be called in a finally block.
      */
-    private static void closePdfResources() throws Exception {
-        Exception closeFailure = null;
-        PDDocument document = StaticResources.getDocument();
-        if (document != null) {
-            try {
+    private static void closePdfResources() {
+        clearCleanupStep("PDDocument", () -> {
+            PDDocument document = StaticResources.getDocument();
+            if (document != null) {
                 document.close();
-            } catch (Exception e) {
-                closeFailure = e;
-            }
-        }
-
-        try {
-            StaticLayoutContainers.closeContrastRatioConsumer();
-        } catch (Exception e) {
-            if (closeFailure != null) {
-                closeFailure.addSuppressed(e);
-            } else {
-                closeFailure = e;
             }
-        }
+        });
+        clearCleanupStep("ContrastRatioConsumer", StaticLayoutContainers::closeContrastRatioConsumer);
 
-        // cleanup static containers
         clearCleanupStep("StaticResources", StaticResources::clear);
         clearCleanupStep("StaticContainers", () -> StaticContainers.updateContainers(null));
         clearCleanupStep(
@@ -107,10 +94,6 @@ private static void closePdfResources() throws Exception {
         clearCleanupStep("StaticStorages", StaticStorages::clearAllContainers);
         clearCleanupStep("StaticCoreContainers", StaticCoreContainers::clearAllContainers);
         clearCleanupStep("StaticXmpCoreContainers", StaticXmpCoreContainers::clearAllContainers);
-
-        if (closeFailure != null) {
-            throw closeFailure;
-        }
     }
 
     /**
@@ -149,7 +132,6 @@ public static void processFile(String inputPdfName, Config config) throws IOExce
      * @throws IOException if unable to process the file
      */
     public static ProcessingResult processFileWithResult(String inputPdfName, Config config) throws IOException {
-        Throwable processingFailure = null;
         try {
             // Phase 1: Extract
             ExtractionResult extraction = extractContents(inputPdfName, config);
@@ -160,25 +142,11 @@ public static ProcessingResult processFileWithResult(String inputPdfName, Config
             long outputNs = System.nanoTime() - t0;
 
             return new ProcessingResult(extraction.getHybridTimings(), extraction.getExtractionNs(), outputNs);
-        } catch (IOException | RuntimeException | Error e) {
-            processingFailure = e;
-            throw e;
         } finally {
-            // Ensures resources are always released, even if processing throws an exception
-            try {
-                closePdfResources();
-            } catch (Exception closeException) {
-                LOGGER.log(Level.WARNING, "Error during PDF resource cleanup", closeException);
-                if (processingFailure != null) {
-                    processingFailure.addSuppressed(closeException);
-                } else {
-                    if (closeException instanceof IOException) {
-                        throw (IOException) closeException;
-                    } else {
-                        throw new IOException("Failed to close PDF resources", closeException);
-                    }
-                }
-            }
+            // Always release resources, even if processing threw. closePdfResources
+            // logs and swallows per-step failures so cleanup cannot mask the original
+            // processing exception.
+            closePdfResources();
         }
     }