Upgrade GitHub Actions to latest versions#327
Conversation
Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
|
Thanks for the contribution! Version bumps verified — all targets are valid. We're merging #326 first (broader scope from the same set of upgrades). Once that lands, could you rebase this PR on git fetch upstream main
git rebase upstream/main
git push --force-with-leaseAfter rebase, we'll merge this one as well. |
ya sure |
📝 WalkthroughWalkthroughGitHub Actions workflow files were updated to use newer major versions of tooling actions: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
51-51: Pin workflow action references to immutable commit SHAs instead of mutable version tags.The three-part GitHub Action references in this file use mutable tags (
@v7,@v5,@v2) which can change unexpectedly. Pin to full commit SHAs (40-character hex) for better supply-chain integrity and reproducibility.Affected lines:
- Line 51:
astral-sh/setup-uv@v7- Line 60:
pnpm/action-setup@v5- Line 115:
softprops/action-gh-release@v2🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml at line 51, Replace the mutable GitHub Action tags with immutable commit SHAs: locate the three action references 'astral-sh/setup-uv@v7', 'pnpm/action-setup@v5', and 'softprops/action-gh-release@v2' in the release.yml and update each to the corresponding full 40-character commit SHA (e.g., 'astral-sh/setup-uv@<full-sha>') so the workflow pins to an exact commit; verify the chosen SHAs are from the action repositories' main (or desired) branch and update only the tag portion of each reference.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yml:
- Line 51: Replace the mutable GitHub Action tags with immutable commit SHAs:
locate the three action references 'astral-sh/setup-uv@v7',
'pnpm/action-setup@v5', and 'softprops/action-gh-release@v2' in the release.yml
and update each to the corresponding full 40-character commit SHA (e.g.,
'astral-sh/setup-uv@<full-sha>') so the workflow pins to an exact commit; verify
the chosen SHAs are from the action repositories' main (or desired) branch and
update only the tag portion of each reference.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 36636929-97c9-40c7-bc05-ed09459a0e6d
📒 Files selected for processing (2)
.github/workflows/release.yml.github/workflows/test-benchmark.yml
Upgrade all GitHub Actions to versions supporting Node.js 24, ahead of the June 2026 deprecation of Node.js 20 runners. - actions/checkout v4 → v6 - actions/setup-java v4 → v5 - actions/setup-python v5 → v6 - actions/setup-node v4 → v6 - actions/upload-artifact v4 → v7 - actions/download-artifact v4 → v8 - astral-sh/setup-uv v4 → v7 - pnpm/action-setup v4 → v5 - softprops/action-gh-release v1 → v2 Closes #326, Closes #327 Co-authored-by: Salman Chishti <salmanmkc@users.noreply.github.com>
|
Thanks again for the contribution — the version bumps were solid and well-documented. Unfortunately, our CI workflows were significantly rewritten on main since this PR was opened, making a clean rebase impractical. I've incorporated these upgrades in #346 with Apologies for the inconvenience, and thanks again! |
Upgrade all GitHub Actions to versions supporting Node.js 24, ahead of the June 2026 deprecation of Node.js 20 runners. - actions/checkout v4 → v6 - actions/setup-java v4 → v5 - actions/setup-python v5 → v6 - actions/setup-node v4 → v6 - actions/upload-artifact v4 → v7 - actions/download-artifact v4 → v8 - astral-sh/setup-uv v4 → v7 - pnpm/action-setup v4 → v5 - softprops/action-gh-release v1 → v2 Closes #326, Closes #327 Co-authored-by: Salman Chishti <salmanmkc@users.noreply.github.com>
Bumps GitHub Actions to their latest versions for bug fixes and security patches.
Changes
astral-sh/setup-uvv4v7pnpm/action-setupv4v5softprops/action-gh-releasev1v2Notes
Worth running the workflows on a branch before merging to make sure everything still works.
Summary by CodeRabbit