Skip to content

Upgrade GitHub Actions for Node 24 compatibility #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
salmanmkc wants to merge 1 commit into from
Closed

Upgrade GitHub Actions for Node 24 compatibility #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
# 1. SETUP
# =================================================================
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Does actions/checkout v6 exist and what are the breaking changes between v4 and v6?

💡 Result:

Yes, actions/checkout v6 exists. The latest version is v6.0.2, released on 2026-01-09. Breaking changes between v4 and v6: From v4 to v5 (v5.0.0): Updated to Node.js 24 runtime. Requires minimum Actions Runner version v2.327.1. From v5 to v6 (v6.0.0): Changed persist-credentials to store credentials in a separate file under $RUNNER_TEMP instead of directly in the local git config. Uses git includeIf directives so git fetch/push etc. continue to work without workflow changes on GitHub-hosted runners. Requires minimum Actions Runner version v2.329.0 for Docker container actions needing authenticated git commands. Not backward-compatible with older runners or non-GitHub runners without support.

Citations:

Review compatibility with breaking changes in actions/checkout v6.

The upgrade from v4 to v6 includes breaking changes that require verification:

  • Credential handling: v6 stores credentials in a separate file under $RUNNER_TEMP with git includeIf directives instead of directly in git config. This requires Actions Runner v2.329.0+.
  • Runtime: Node.js 24 runtime (v5+).
  • Backward compatibility: Not compatible with older or non-GitHub hosted runners without git includeIf support.

Verify this workflow runs on compatible runner versions and test credential handling if this workflow uses authenticated git operations.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yml at line 23, The workflow now uses
actions/checkout@v6 which introduces breaking changes in credential handling and
runtime expectations; either pin back to actions/checkout@v4 or update the
workflow/runners to meet v6 requirements: ensure the GitHub Actions runner
version is >= 2.329.0, that the runner supports git includeIf (for credentials
written to $RUNNER_TEMP), and that any steps relying on Node runtime meet Node
24 if using v5+ semantics; update the release.yml reference (uses:
actions/checkout@v6) accordingly, and add a short validation step to exercise
authenticated git operations to verify credentials are correctly handled on your
targeted runners.


- name: Initialize VERSION
run: |
Expand All @@ -31,7 +31,7 @@ jobs:
fi

- name: Set up Java
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: '21'
distribution: 'temurin'
Expand All @@ -43,15 +43,15 @@ jobs:
gpg-passphrase: ${{ secrets.MAVEN_GPG_PASSPHRASE }}

- name: Set up Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install uv
uses: astral-sh/setup-uv@v4

- name: Set up Node.js and pnpm
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '20'
registry-url: 'https://registry.npmjs.org'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
sync:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Push to homepage repo
# Pinned to v1.7.3 for security - verify before updating
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/test-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
lfs: true

- name: Setup Java
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: '21'
Expand All @@ -31,7 +31,7 @@ jobs:
uses: astral-sh/setup-uv@v4

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '20'

Expand All @@ -49,7 +49,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload build artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: java-build
path: java/opendataloader-pdf-cli/target/*.jar
Expand All @@ -60,18 +60,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
lfs: true

- name: Setup Java
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: '21'

- name: Download build artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: java-build
path: java/opendataloader-pdf-cli/target/
Expand All @@ -92,7 +92,7 @@ jobs:

- name: Comment benchmark results on PR
if: github.event_name == 'pull_request'
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:
});

- name: Upload evaluation results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
if: always()
with:
name: benchmark-results
Expand Down