Auto-tagging - Improve location of Caption structure element#377
Merged
MaximPlusov merged 3 commits intoauto_taggingfrom Apr 10, 2026
Merged
Auto-tagging - Improve location of Caption structure element#377MaximPlusov merged 3 commits intoauto_taggingfrom
MaximPlusov merged 3 commits intoauto_taggingfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LonelyMidoriya
force-pushed
the
auto-tagging-caption
branch
from
924707b to
39293ad
Compare
MaximPlusov
approved these changes
Apr 10, 2026
bundolee
added a commit
that referenced
this pull request
Apr 14, 2026
…377 Replace the 2-pass caption-to-float mapping (521b274) with Raman Kakhnovich's addKids/addCaptionIfPresent pattern from origin/auto_tagging #377 (193a3b5). Key changes: - addKids(): first pass collects Captions by linkedContentId, second pass creates non-Caption struct elements (skipping Captions) - addCaptionIfPresent(): called by Figure/Table/List/Part after struct elem creation, attaches Caption as first or last child based on spatial position - isCaptionFirstChild(): compares caption vs parent bbox to decide placement - addStructElement() overload with isFirstKid for Caption-first insertion - Removed: captionToFloat map, floatStructElems map, isFloatElement() - Kept: heading normalization, Link annotations, Formula, EnrichedImageChunk Reference: Kakhnovich Raman's origin/auto_tagging 193a3b5 (#377) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bundolee
added a commit
that referenced
this pull request
Apr 14, 2026
…377 Replace the 2-pass caption-to-float mapping (521b274) with Raman Kakhnovich's addKids/addCaptionIfPresent pattern from origin/auto_tagging #377 (193a3b5). Key changes: - addKids(): first pass collects Captions by linkedContentId, second pass creates non-Caption struct elements (skipping Captions) - addCaptionIfPresent(): called by Figure/Table/List/Part after struct elem creation, attaches Caption as first or last child based on spatial position - isCaptionFirstChild(): compares caption vs parent bbox to decide placement - addStructElement() overload with isFirstKid for Caption-first insertion - Removed: captionToFloat map, floatStructElems map, isFloatElement() - Kept: heading normalization, Link annotations, Formula, EnrichedImageChunk Reference: Kakhnovich Raman's origin/auto_tagging 193a3b5 (#377) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bundolee
added a commit
that referenced
this pull request
Apr 15, 2026
…377 Replace the 2-pass caption-to-float mapping (521b274) with Raman Kakhnovich's addKids/addCaptionIfPresent pattern from origin/auto_tagging #377 (193a3b5). Key changes: - addKids(): first pass collects Captions by linkedContentId, second pass creates non-Caption struct elements (skipping Captions) - addCaptionIfPresent(): called by Figure/Table/List/Part after struct elem creation, attaches Caption as first or last child based on spatial position - isCaptionFirstChild(): compares caption vs parent bbox to decide placement - addStructElement() overload with isFirstKid for Caption-first insertion - Removed: captionToFloat map, floatStructElems map, isFloatElement() - Kept: heading normalization, Link annotations, Formula, EnrichedImageChunk Reference: Kakhnovich Raman's origin/auto_tagging 193a3b5 (#377) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bundolee
added a commit
that referenced
this pull request
Apr 15, 2026
…377 Replace the 2-pass caption-to-float mapping (521b274) with Raman Kakhnovich's addKids/addCaptionIfPresent pattern from origin/auto_tagging #377 (193a3b5). Key changes: - addKids(): first pass collects Captions by linkedContentId, second pass creates non-Caption struct elements (skipping Captions) - addCaptionIfPresent(): called by Figure/Table/List/Part after struct elem creation, attaches Caption as first or last child based on spatial position - isCaptionFirstChild(): compares caption vs parent bbox to decide placement - addStructElement() overload with isFirstKid for Caption-first insertion - Removed: captionToFloat map, floatStructElems map, isFloatElement() - Kept: heading normalization, Link annotations, Formula, EnrichedImageChunk Reference: Kakhnovich Raman's origin/auto_tagging 193a3b5 (#377) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: