fix(client): replace server_version property with get_server_version() method (#83)

The async client exposed get_server_version() as a method; the sync
client exposed server_version as a property, hiding the I/O cost. This
inconsistency made the API misleading — property access should not
trigger a network call.

Changes:
- Add get_server_version() to ConfigClient (same logic as the old property)
- Deprecate the server_version property with DeprecationWarning pointing
  to get_server_version()
- Update check_compatibility() to call get_server_version() directly
- Update test suite: rename cached-fetch test, add deprecation-warning test

Co-Authored-By: Claude <noreply@anthropic.com>

Closes #52

Author: zeevdr

sdk/src/opendecree/client.py

@@ -11,6 +11,7 @@
 
 from __future__ import annotations
 
+import warnings
 from datetime import timedelta
 from typing import TYPE_CHECKING, overload
 
@@ -108,9 +109,8 @@ def __enter__(self) -> ConfigClient:
     def __exit__(self, *exc: object) -> None:
         self.close()
 
-    @property
-    def server_version(self) -> ServerVersion:
-        """The server's version, fetched once and cached.
+    def get_server_version(self) -> ServerVersion:
+        """Fetch the server's version, cached after first call.
 
         Returns:
             ServerVersion with version and commit strings.
@@ -124,6 +124,16 @@ def server_version(self) -> ServerVersion:
             )
         return self._server_version
 
+    @property
+    def server_version(self) -> ServerVersion:
+        """Deprecated. Use :meth:`get_server_version` instead."""
+        warnings.warn(
+            "server_version property is deprecated; use get_server_version() instead.",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+        return self.get_server_version()
+
     def check_compatibility(self) -> None:
         """Check that the server version is compatible with this SDK.
 
@@ -135,7 +145,7 @@ def check_compatibility(self) -> None:
                 supported range.
             UnavailableError: If the server is unreachable.
         """
-        check_version_compatible(self.server_version.version)
+        check_version_compatible(self.get_server_version().version)
 
     # --- get() with @overload for type safety ---
 

sdk/tests/test_compat.py

@@ -126,11 +126,11 @@ async def test_async_fetch_server_version():
     assert sv == ServerVersion(version="0.3.1", commit="abc123")
 
 
-# --- ConfigClient.server_version + check_compatibility ---
+# --- ConfigClient.get_server_version + check_compatibility ---
 
 
-def test_client_server_version_cached():
-    """server_version property fetches once, returns cached."""
+def test_client_get_server_version_cached():
+    """get_server_version() fetches once, returns cached."""
     with patch("opendecree.client.create_channel"):
         from opendecree import ConfigClient
 
@@ -147,16 +147,32 @@ def test_client_server_version_cached():
         client._server_version = None
 
         # First call fetches
-        v1 = client.server_version
+        v1 = client.get_server_version()
         assert v1.version == "0.3.1"
         assert mock_stub.GetServerInfo.call_count == 1
 
         # Second call returns cached
-        v2 = client.server_version
+        v2 = client.get_server_version()
         assert v2 is v1
         assert mock_stub.GetServerInfo.call_count == 1
 
 
+def test_client_server_version_property_deprecated():
+    """server_version property emits DeprecationWarning."""
+    with patch("opendecree.client.create_channel"):
+        from opendecree import ConfigClient
+
+        client = ConfigClient.__new__(ConfigClient)
+        client._timeout = 5.0
+        client._server_version = ServerVersion(version="0.3.1", commit="abc")
+        client._version_stub = MagicMock()
+        client._version_pb2 = MagicMock()
+
+        with pytest.warns(DeprecationWarning, match="get_server_version"):
+            sv = client.server_version
+        assert sv.version == "0.3.1"
+
+
 def test_client_check_compatibility_passes():
     with patch("opendecree.client.create_channel"):
         from opendecree import ConfigClient