Skip to content

build: gate prepublishOnly on lint, typecheck, and tests#103

Merged
zeevdr merged 1 commit into
mainfrom
issue-69-prepublish
May 28, 2026
Merged

build: gate prepublishOnly on lint, typecheck, and tests#103
zeevdr merged 1 commit into
mainfrom
issue-69-prepublish

Conversation

@zeevdr
Copy link
Copy Markdown
Member

@zeevdr zeevdr commented May 28, 2026

Summary

  • Prevents publishing a broken package by running lint, typecheck, and unit tests before the build step.
  • prepublishOnly now chains npm run pre-commit (biome + tsc --noEmit + vitest) ahead of npm run build.

Test plan

  • Confirm npm publish (dry-run) runs biome check, tsc, and vitest before building.
  • Introduce a lint error, verify npm publish aborts before the build.

Closes #69

Run pre-commit (biome + tsc --noEmit + vitest) before building on
publish, so a broken package can never reach the registry.

Closes #69

Co-Authored-By: Claude <noreply@anthropic.com>
@zeevdr zeevdr added this to the Beta Readiness milestone May 28, 2026
@zeevdr zeevdr added size: S Quick win — a few hours or less priority: P2 Nice-to-have labels May 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@zeevdr zeevdr enabled auto-merge (squash) May 28, 2026 17:47
@zeevdr zeevdr merged commit 4097dbb into main May 28, 2026
14 checks passed
@zeevdr zeevdr deleted the issue-69-prepublish branch May 28, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: P2 Nice-to-have size: S Quick win — a few hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prepublishOnly should run lint + test before build

1 participant