Add expectedChecksum support to set, setMany, and setNull#85
Merged
Conversation
Adds optimistic concurrency control to all write methods. Callers can pass a checksum from a previous GetField/GetConfig response to prevent lost updates when multiple actors modify the same field concurrently. The server returns ABORTED on mismatch, which the SDK maps to ChecksumMismatchError. - set/setNull: new expectedChecksum option - setMany: new expectedChecksums record option (per-field) Co-Authored-By: Claude <noreply@anthropic.com> Closes #54
zeevdr
added
size: S
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChecksumMismatchErrorwas exported but unreachable because no write method ever sent a checksum to the server; this surfaces it as a real, usable API.expectedChecksumtoset()andsetNull(), andexpectedChecksums(per-field record) tosetMany(), so callers can enforce optimistic concurrency when writing config values.Test plan
set()passesexpectedChecksumthrough to the proto requestset()raisesChecksumMismatchErrorwhen the server returnsABORTEDsetMany()maps per-field checksums onto the correctFieldUpdateentries; fields without a checksum getundefinedsetMany()raisesChecksumMismatchErroronABORTEDsetNull()passesexpectedChecksumthrough to the proto requestsetNull()raisesChecksumMismatchErroronABORTEDCloses #54