feat(tls): expose custom CA and mTLS options#87
Merged
Conversation
Add TlsOptions interface with rootCerts, privateKey, certChain fields. Wire them through createChannel into credentials.createSsl. Export TlsOptions from the public index. Update docs with custom-CA and mTLS examples. Add three new TLS tests. Closes #56 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
size: S
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tlsoption onClientOptionsacceptingrootCerts,privateKey, andcertChain(allBuffer, all optional).credentials.createSsl()inchannel.ts, with no change to the insecure path.Test plan
creates TLS channel with custom root CA— verifiestls.rootCertsaccepted without errorcreates TLS channel with mTLS client cert— spies oncredentials.createSslto verify all three buffers are forwardedignores tls option when insecure is true— insecure path unchangedTlsOptionsexported from public index and verified withtsc --noEmitCloses #56