fix: generate SUPPORTED_SERVER_VERSION from package.json and align README#89
Merged
Conversation
…ADME SUPPORTED_SERVER_VERSION was hardcoded in src/index.ts and the README claimed server v0.3.0+, contradicting the actual constraint of >=0.8.0,<1.0.0. - Add `supportedServerVersion` field to package.json as the single source of truth for the supported server version range - Extend scripts/gen-version.mjs to emit SUPPORTED_SERVER_VERSION into src/version.ts alongside VERSION; existing check:version CI job now catches drift for both constants - Remove the hardcoded constant from src/index.ts; re-export from version.js - Update README Requirements section to reflect the actual range Closes #60 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
size: S
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORTED_SERVER_VERSIONwas hardcoded insrc/index.tswith no connection topackage.json, making it easy for the value to drift silently across releases.>=0.8.0,<1.0.0).package.json#supportedServerVersionas the single source of truth, generated intosrc/version.tsalongsideVERSIONso the existingcheck:versionCI job catches both constants.Test plan
npm run check:versionpasses after regenerationnpm run typecheckcleanvitest run)Closes #60