Add contract tests against real grpc-js mock server#90
Merged
Conversation
Adds test/contract.test.ts with an in-process grpc-js server fixture that exercises get, set, setMany, and watch RPCs through the actual generated proto stubs. This catches signature drift that mock-based tests cannot detect, closing the gap described in issue #58. The fixture binds on port 0, registers per-test mutable handlers for each RPC, and tears down cleanly after every test. The subscribe test waits on an explicit Promise to avoid the race between watcher.start() returning and the server-side streaming handler being invoked. Closes #58 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
size: M
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigServiceService,ServerServiceService), so any mismatch between the client's expectations and the wire format will be caught immediately.ConfigWatcherlifecycle (snapshot viaGetConfig+ live updates viaSubscribe) against a real streaming server.Test plan
get()round-trips string, integer, and boolean values through proto serializationget()raisesNotFoundErrorwhen the server returnsNOT_FOUNDset()/setNumber()/setBool()/setNull()send correctly typed proto valuessetMany()sends a batch of mixed types in a singleSetFieldsRPCwatch()loads the initial snapshot fromGetConfigand propagates a change pushed through theSubscribestreamwatch()applies the field default when the field is absent from the snapshotnpm test)npm run pre-commit)Closes #58