feat(watcher): surface subscription errors via subscriptionError event#93
Merged
Conversation
zeevdr
added
size: S
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ConfigWatcher now extends EventEmitter and emits a typed 'subscriptionError' event whenever the Subscribe stream encounters an error. Both retryable errors (UNAVAILABLE, INTERNAL — which trigger reconnection) and fatal errors (all others — which stop the watcher) are surfaced, letting callers log or monitor connection health without polling. The ConfigWatcherEvents interface is exported for consumers that want typed listener signatures. The 'subscriptionError' name is intentional: using 'error' would throw on unhandled listeners per Node.js convention. Closes #61 Co-Authored-By: Claude <noreply@anthropic.com>
…ener test Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
force-pushed
the
feat/watcher-subscription-errors
branch
from
db04e32 to
8edbcad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigWatchernow extendsEventEmitterand emits a'subscriptionError'event on every Subscribe stream error, giving callers visibility into connection health without requiring polling or log scraping.ConfigWatcherEventsinterface is exported for consumers that want fully-typed listener signatures.Test plan
status.UNAVAILABLE)status.PERMISSION_DENIED)npm test)npm run build)npx biome check src/ test/)Closes #61