feat(client): add setToken() for JWT token rotation#94
Merged
Conversation
Adds ConfigClient.setToken(token) to allow callers to rotate bearer tokens after construction. The method mutates the shared Metadata object, so active ConfigWatcher instances automatically use the new token on their next reconnect without any additional wiring. When called on a client that was constructed in header-mode (x-subject, x-role, x-tenant-id), setToken() removes those headers and switches fully to JWT auth for all subsequent RPCs. Closes #62 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
size: S
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setToken(token)mutates the sharedMetadataobject in place, so activeConfigWatcherinstances automatically use the new token on their next reconnect with no extra wiring.Test plan
setToken()on a header-mode client: subsequentget()sendsBearer <new-token>and clearsx-subject/x-rolesetToken()on a token-mode client: subsequentget()sends the rotated tokenCloses #62