fix(examples): link to local SDK source instead of npm registry#96
Merged
Conversation
The examples/package.json previously resolved @opendecree/sdk from npm (>=0.1.0), meaning examples were always tested against the published version rather than local source. This switches the dependency to file:../ so that any in-progress SDK changes are exercised by the examples. Closes #64 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…k in CI Two issues caused the Examples CI job to fail after switching to file:../: - The SDK's dist/ directory is not present in CI until built, so TypeScript could not resolve @opendecree/sdk types via the file: link. - @types/node was previously pulled in transitively from the npm-registry version of the SDK (via protobufjs); with file:../ that transitive dep is gone, breaking console and other Node globals. Adds `npm run build` to the examples CI job and declares @types/node explicitly in examples/package.json devDependencies. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@opendecree/sdkfrom the npm registry (>=0.1.0) instead of local source, so in-progress SDK changes were never exercised by the examples.file:../so examples always use the current local version.examples/package-lock.json— removes ~330 lines of pulled-in registry metadata now replaced by a single local symlink entry.Test plan
npm run typecheckpasses inexamples/with no errorsexamples/package-lock.jsonresolves@opendecree/sdkas"resolved": ".."(local link), not an npm registry URLCloses #64