feat(linter): enable useAwait and noFloatingPromises biome rules#98
Merged
Conversation
Adds two SDK-rigor lint rules to biome.json: - suspicious/useAwait (error): async functions must contain an await expression - nursery/noFloatingPromises (error): Promise-like statements must be handled Fixes all 11 violations surfaced by useAwait. The affected methods in ConfigClient (getAll, set, setNumber, setBool, setTime, setDuration, setMany, setNull, setTyped, asyncDispose) and ConfigWatcher (stop) were marked async but delegated directly to Promise-returning helpers without awaiting, making the async modifier unnecessary. Removed async from each; asyncDispose and stop now return Promise.resolve() explicitly to satisfy their Promise<void> return types. Also bumps the biome schema URL from 2.4.13 to 2.4.15. Closes #66 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Biome's useAwait rule does not recognise `await using` as an await expression, producing false positives in the two asyncDispose tests. Add biome-ignore suppressions with an explanation. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suspicious/useAwaitandnursery/noFloatingPromises) to enforce correct async/Promise handling across the SDK.asyncmodifiers from 11 methods inConfigClientandConfigWatcherthat delegated directly to Promise-returning helpers without awaiting.asyncDisposeandstopnow explicitly returnPromise.resolve()to satisfy theirPromise<void>signatures without the async wrapper.Test plan
npx biome check src/passes with zero diagnostics under the new rulesnpx tsc --noEmitreports no type errorsnpm test— all 225 tests passCloses #66