fix(compat): resolve cyclic import between compat.ts and index.ts#99
Merged
Conversation
Import SUPPORTED_SERVER_VERSION directly from version.ts instead of index.ts, which itself imports from client.ts, creating a cycle. version.ts is the canonical source for this constant. Closes #67 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compat.tsimportedSUPPORTED_SERVER_VERSIONfromindex.ts, creating a cycle sinceindex.tsre-exports fromclient.tswhich may itself import fromcompat.ts.version.tsis already the canonical source for this constant —index.tsjust re-exports it.compat.tsdirectly atversion.tsbreaks the cycle with a one-line change.Test plan
npm run build— compiles cleanly with no errorsnpm test— all 225 tests passCloses #67