helm: sane resource defaults, NetworkPolicy template, pull-Always#261
Merged
Conversation
Pods previously shipped with `resources: {}` and `imagePullPolicy:
IfNotPresent`, so a single replica could starve its node and
security-patch updates on a moving tag never propagated. The chart
also had no NetworkPolicy, leaving egress wide open in multi-tenant
clusters.
- Default `requests: 100m/128Mi`, `limits: 1/512Mi`; documented as
override-friendly for benchmarking and larger sizing.
- Default `imagePullPolicy: Always`; production guidance is to pin
`image.tag` by digest and flip back to `IfNotPresent`.
- Add `networkPolicy.yaml` gated on `networkPolicy.enabled` (off by
default during alpha). Allows ingress to gRPC/HTTP ports plus
configurable egress CIDRs for PG, Redis, JWKS, OTel, and DNS.
- Add `tests/template_test.sh` asserting render contents + helm lint.
- Wire a `helm` job into CI gated on `deploy/helm/**` paths.
Closes #220.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zeevdr
added
enhancement
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources: {}— sane defaults (100m/128Mi requests, 1/512Mi limits) keep one pod from starving its node, with override + benchmarking guidance in the chart README.imagePullPolicydefaults toAlwaysso security-patch updates on a moving tag propagate without a manual rollout; production guidance is to pin by digest and flip back toIfNotPresent.networkPolicy.enabled, off by default in alpha) restricts ingress to the gRPC/HTTP ports and egress to configurable CIDRs for Postgres, Redis, JWKS, OTel + DNS.Test plan
./deploy/helm/decree/tests/template_test.sh— asserts default render contents, NetworkPolicy-enabled render, andhelm lintcleanhelmgated ondeploy/helm/**paths runs the same scripthelm lintcleanCloses #220
🤖 Generated with Claude Code