fix(schema): correct metaSchemaURL to decree-schema.json#262
Merged
Conversation
The constant referenced a singular decree.json that will never be published. The actual artifacts are decree-schema.json (validates *.decree.schema.yaml) and decree-config.json (validates *.decree.config.yaml). Update the URL emitted on schema export to match the schema artifact filename, fix the matching test fixture, and update the design brief's URL pattern + schemastore example to show two catalog entries. Refs #125
zeevdr
force-pushed
the
fix/meta-schema-url-filename
branch
from
8e11eff to
bb231a4
Compare
4 tasks
zeevdr
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 0 of the schemas-publishing work (#125). The
metaSchemaURLconstant emitted byinternal/schema/yaml.goon schema export referenced a singulardecree.json, but the actual published artifacts are two files:decree-schema.json(validates*.decree.schema.yaml) anddecree-config.json(validates*.decree.config.yaml). Without this fix, every exported schema would carry a\$schemaURL that resolves to a 404 once Pages goes live.Touched:
internal/schema/yaml.go— the constant.internal/schema/yaml_test.go— test fixture string (the negative-casehttp://example.com/decree.jsonat line 317 is intentionally kept)..agents/context/schema-spec.md— modeline + top-level-shape examples now usedecree-schema.json; the URL pattern documents both files; the schemastore section shows two catalog entries (one per file).Pure docs/string change, no behavior change beyond the URL constant. Mechanical follow-up to #259 (the
.io→.devrename).This must merge before Pages is enabled in #125 — the running binary will emit the URL on every schema export, and that URL must resolve.
Refs #125
Test plan
go test ./internal/schema/...passesgolangci-lint run ./...— 0 issuesgrep -rn 'schema/v0\.1\.0/decree\.json' .returns nothing (apart from the negative-testexample.comURL)