feat(configwatcher): add NewGroup/Fill for struct-based field watching#869
Merged
Conversation
zeevdr
added
enhancement
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- The decree CLI had no Homebrew install path; users had to use go install or build from source. - goreleaser.yaml was already configured to auto-push to opendecree/homebrew-tap on release; created initial formula stub in the tap repo (PR #1) with real checksums from v0.11.0-alpha.1. - Updated docs/getting-started.md to list Homebrew as the primary install method above go install. Closes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
w.String()/w.Bool()call per field and separateGet()calls to read them; there was no struct-oriented API.Watcher.NewGroup(s *T)that introspectsdecreestruct tags and registers each tagged field as a watched value in one call.Group.Fill(s *T)that reads current values into any struct of the same type, providing a snapshot-style read API.Test plan
go test ./...passes insdk/configwatcherNewGroup(&Config{})registers all tagged fields,Fill(&cfg)populates them correctlyCloses #18