Fix sonar complaints.

zxBCN Valeriu_Tuguran,Constantin (IT EDP) EXTERNAL · zxBCN Valeriu_Tuguran,Constantin (IT EDP) EXTERNAL · commit 478027bbb167 · 2026-03-20T09:22:13.000+01:00
diff --git a/api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/controller/ComponentsResponseFactory.java b/api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/controller/ComponentsResponseFactory.java
@@ -12,7 +12,7 @@ private ComponentsResponseFactory() {
     public static CreateComponentResponse error(String projectId) {
         CreateComponentResponse response = new CreateComponentResponse();
         response.setErrorCode(HttpStatus.INTERNAL_SERVER_ERROR.value());
-        response.setMessage("Failed to create component for project '" + projectId);
+        response.setMessage("Failed to create component for project '" + projectId + "'");
         return response;
     }
 
@@ -23,7 +23,7 @@ public static CreateComponentResponse entityCreated(String projectId, String com
         return response;
     }
 
-    public static ResponseEntity toResponseEntity(CreateComponentResponse response) {
-        return new ResponseEntity(response, HttpStatus.valueOf(response.getErrorCode()));
+    public static ResponseEntity<CreateComponentResponse> toResponseEntity(CreateComponentResponse response) {
+        return new ResponseEntity<>(response, HttpStatus.valueOf(response.getErrorCode()));
     }
 }
diff --git a/api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/service/ComponentsService.java b/api-project-component-v0/src/main/java/org/opendevstack/apiservice/project/service/ComponentsService.java
@@ -32,10 +32,12 @@ public boolean isHealthy() {
         }
 
         public Component getProjectComponent(String projectId, String componentId) {
+            log.info("Get component with id '" + componentId + "' for project '" + projectId + "'");
             return null;
         }
 
         public Component createProjectComponent(String projectId, CreateComponentRequest createComponentRequest) {
+            log.info("Creating component for project '" + projectId + "'" + " with request: " + createComponentRequest);
             return null;
         }
     }
diff --git a/api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/controller/ProjectComponentsControllerTest.java b/api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/controller/ProjectComponentsControllerTest.java
@@ -34,34 +34,37 @@ void setup() {
     @Test
     void testCreateProjectComponent_whenSuccess_thenReturnOk() throws Exception {
         Component testComponent = buildTestComponent();
+        String testProjectId = "testProjectId";
         CreateComponentRequest testCreateComponentRequest = buildTestCreateComponentRequest();
-        CreateComponentResponse testServiceResponseSuccess = buildTestCreateComponentResponseSuccess();
+        CreateComponentResponse testServiceResponseSuccess = buildTestCreateComponentResponseSuccess(testComponent.getName(),
+                testProjectId);
 
         when(componentsService.createProjectComponent(anyString(), any(CreateComponentRequest.class)))
                 .thenReturn(testComponent);
 
-        ResponseEntity<CreateComponentResponse> response = projectComponentsController.createProjectComponent("testId",
+        ResponseEntity<CreateComponentResponse> response = projectComponentsController.createProjectComponent(testProjectId,
                 testCreateComponentRequest);
 
         assertThat(response.getStatusCode()).isEqualTo(HttpStatus.CREATED);
         assertThat(response.getBody()).isNotNull();
-        assertThat(response.getBody().equals(testServiceResponseSuccess));
+        assertThat(response.getBody()).isEqualTo(testServiceResponseSuccess);
     }
 
     @Test
     void testCreateProjectComponent_whenFailure_thenReturnErrorResponse() throws Exception {
         CreateComponentRequest testCreateComponentRequest = buildTestCreateComponentRequest();
-        CreateComponentResponse testServiceResponseFailure = buildTestCreateComponentResponseFailure();
+        String testProjectId = "testProjectId";
+        CreateComponentResponse testServiceResponseFailure = buildTestCreateComponentResponseFailure(testProjectId);
 
         when(componentsService.createProjectComponent(anyString(), any(CreateComponentRequest.class)))
                 .thenReturn(null);
 
-        ResponseEntity<CreateComponentResponse> response = projectComponentsController.createProjectComponent("projectId",
+        ResponseEntity<CreateComponentResponse> response = projectComponentsController.createProjectComponent(testProjectId,
                 testCreateComponentRequest);
 
         assertThat(response.getStatusCode()).isEqualTo(HttpStatus.INTERNAL_SERVER_ERROR);
         assertThat(response.getBody()).isNotNull();
-        assertThat(response.getBody().equals(testServiceResponseFailure));
+        assertThat(response.getBody()).isEqualTo(testServiceResponseFailure);
     }
 
     @Test
@@ -76,7 +79,7 @@ void testGetProjectComponent_whenSuccess_thenReturnOk() throws Exception {
 
         assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
         assertThat(response.getBody()).isNotNull();
-        assertThat(response.getBody().equals(testComponent));
+        assertThat(response.getBody()).isEqualTo(testComponent);
     }
 
     @Test
diff --git a/api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/service/ComponentsServiceTest.java b/api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/service/ComponentsServiceTest.java
@@ -46,7 +46,7 @@ void testGetProjectComponent_whenNoComponentFound_thenReturnNull() throws Except
                 .thenReturn(null);
 
         Component retrievedComponent = componentsService.getProjectComponent("testId", "testId");
-        assertThat(retrievedComponent).isEqualTo(null);
+        assertThat(retrievedComponent).isNull();
     }
 
     @Test
@@ -70,6 +70,6 @@ void testCreateProjectComponent_whenFailure_thenReturnNull() throws Exception {
                 .thenReturn(null);
 
         Component retrievedComponent = componentsService.createProjectComponent("testId", testRequest);
-        assertThat(retrievedComponent).isEqualTo(null);
+        assertThat(retrievedComponent).isNull();
     }
 }
diff --git a/api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/util/TestHelper.java b/api-project-component-v0/src/test/java/org/opendevstack/apiservice/project/util/TestHelper.java
@@ -24,17 +24,17 @@ public static CreateComponentRequest buildTestCreateComponentRequest() {
         return request;
     }
 
-    public static CreateComponentResponse buildTestCreateComponentResponseSuccess() {
+    public static CreateComponentResponse buildTestCreateComponentResponseSuccess(String componentName, String projectId) {
         CreateComponentResponse response = new CreateComponentResponse();
         response.setErrorCode(HttpStatus.CREATED.value());
-        response.setMessage("success");
+        response.setMessage(componentName + " component created successfully in project " + projectId);
         return response;
     }
 
-    public static CreateComponentResponse buildTestCreateComponentResponseFailure() {
+    public static CreateComponentResponse buildTestCreateComponentResponseFailure(String projectId) {
         CreateComponentResponse response = new CreateComponentResponse();
         response.setErrorCode(HttpStatus.INTERNAL_SERVER_ERROR.value());
-        response.setMessage("failure");
+        response.setMessage("Failed to create component for project '" + projectId + "'");
         return response;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ private ComponentsResponseFactory() {`
`12`	`12`	`public static CreateComponentResponse error(String projectId) {`
`13`	`13`	`CreateComponentResponse response = new CreateComponentResponse();`
`14`	`14`	`response.setErrorCode(HttpStatus.INTERNAL_SERVER_ERROR.value());`
`15`		`- response.setMessage("Failed to create component for project '" + projectId);`
	`15`	`+ response.setMessage("Failed to create component for project '" + projectId + "'");`
`16`	`16`	`return response;`
`17`	`17`	`}`
`18`	`18`
`@@ -23,7 +23,7 @@ public static CreateComponentResponse entityCreated(String projectId, String com`
`23`	`23`	`return response;`
`24`	`24`	`}`
`25`	`25`
`26`		`- public static ResponseEntity toResponseEntity(CreateComponentResponse response) {`
`27`		`- return new ResponseEntity(response, HttpStatus.valueOf(response.getErrorCode()));`
	`26`	`+ public static ResponseEntity<CreateComponentResponse> toResponseEntity(CreateComponentResponse response) {`
	`27`	`+ return new ResponseEntity<>(response, HttpStatus.valueOf(response.getErrorCode()));`
`28`	`28`	`}`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,12 @@ public boolean isHealthy() {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`public Component getProjectComponent(String projectId, String componentId) {`
	`35`	`+ log.info("Get component with id '" + componentId + "' for project '" + projectId + "'");`
`35`	`36`	`return null;`
`36`	`37`	`}`
`37`	`38`
`38`	`39`	`public Component createProjectComponent(String projectId, CreateComponentRequest createComponentRequest) {`
	`40`	`+ log.info("Creating component for project '" + projectId + "'" + " with request: " + createComponentRequest);`
`39`	`41`	`return null;`
`40`	`42`	`}`
`41`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ void testGetProjectComponent_whenNoComponentFound_thenReturnNull() throws Except`
`46`	`46`	`.thenReturn(null);`
`47`	`47`
`48`	`48`	`Component retrievedComponent = componentsService.getProjectComponent("testId", "testId");`
`49`		`- assertThat(retrievedComponent).isEqualTo(null);`
	`49`	`+ assertThat(retrievedComponent).isNull();`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`@Test`
`@@ -70,6 +70,6 @@ void testCreateProjectComponent_whenFailure_thenReturnNull() throws Exception {`
`70`	`70`	`.thenReturn(null);`
`71`	`71`
`72`	`72`	`Component retrievedComponent = componentsService.createProjectComponent("testId", testRequest);`
`73`		`- assertThat(retrievedComponent).isEqualTo(null);`
	`73`	`+ assertThat(retrievedComponent).isNull();`
`74`	`74`	`}`
`75`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,17 +24,17 @@ public static CreateComponentRequest buildTestCreateComponentRequest() {`
`24`	`24`	`return request;`
`25`	`25`	`}`
`26`	`26`
`27`		`- public static CreateComponentResponse buildTestCreateComponentResponseSuccess() {`
	`27`	`+ public static CreateComponentResponse buildTestCreateComponentResponseSuccess(String componentName, String projectId) {`
`28`	`28`	`CreateComponentResponse response = new CreateComponentResponse();`
`29`	`29`	`response.setErrorCode(HttpStatus.CREATED.value());`
`30`		`- response.setMessage("success");`
	`30`	`+ response.setMessage(componentName + " component created successfully in project " + projectId);`
`31`	`31`	`return response;`
`32`	`32`	`}`
`33`	`33`
`34`		`- public static CreateComponentResponse buildTestCreateComponentResponseFailure() {`
	`34`	`+ public static CreateComponentResponse buildTestCreateComponentResponseFailure(String projectId) {`
`35`	`35`	`CreateComponentResponse response = new CreateComponentResponse();`
`36`	`36`	`response.setErrorCode(HttpStatus.INTERNAL_SERVER_ERROR.value());`
`37`		`- response.setMessage("failure");`
	`37`	`+ response.setMessage("Failed to create component for project '" + projectId + "'");`
`38`	`38`	`return response;`
`39`	`39`	`}`
`40`	`40`	`}`