Skip to content

Commit 726198a

Browse files
committed
Update API base path to /api/pub/v0 and refactor ProjectServiceImpl constructor
1 parent a7eaadf commit 726198a

5 files changed

Lines changed: 6 additions & 128 deletions

File tree

api-project/openapi/api-project.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
name: ODS Team
77
version: v0.0.1
88
servers:
9-
- url: http://{baseurl}/api/v0
9+
- url: http://{baseurl}/api/pub/v0
1010
variables:
1111
baseurl:
1212
default: localhost:8080

api-project/src/main/java/org/opendevstack/apiservice/project/controller/ProjectController.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,12 @@
1919
import org.springframework.web.bind.annotation.RestController;
2020

2121
@RestController
22-
@RequestMapping("/api/v0/projects")
22+
@RequestMapping(ProjectController.API_BASE_PATH)
2323
@AllArgsConstructor
2424
@Slf4j
2525
public class ProjectController implements ProjectsApi {
26+
27+
public static final String API_BASE_PATH = "/api/pub/v0/projects";
2628

2729
private final ProjectsFacade projectsFacade;
2830

api-project/src/test/java/org/opendevstack/apiservice/project/controller/ProjectControllerIntegrationTest.java

Lines changed: 0 additions & 81 deletions
This file was deleted.

service-projects/src/main/java/org/opendevstack/apiservice/serviceproject/service/impl/ProjectServiceImpl.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.opendevstack.apiservice.serviceproject.service.impl;
22

3+
import lombok.AllArgsConstructor;
34
import lombok.extern.slf4j.Slf4j;
45
import org.opendevstack.apiservice.externalservice.bitbucket.service.BitbucketService;
56
import org.opendevstack.apiservice.externalservice.jira.service.JiraService;
@@ -8,11 +9,11 @@
89
import org.opendevstack.apiservice.serviceproject.model.CreateProjectResponse;
910
import org.opendevstack.apiservice.serviceproject.service.GenerateProjectKeyService;
1011
import org.opendevstack.apiservice.serviceproject.service.ProjectService;
11-
import org.springframework.beans.factory.annotation.Autowired;
1212
import org.springframework.stereotype.Service;
1313

1414
@Service
1515
@Slf4j
16+
@AllArgsConstructor
1617
public class ProjectServiceImpl implements ProjectService {
1718

1819
private final OpenshiftService openshiftService;
@@ -22,16 +23,6 @@ public class ProjectServiceImpl implements ProjectService {
2223
private final JiraService jiraService;
2324

2425
private final GenerateProjectKeyService generateProjectKeyService;
25-
26-
@Autowired
27-
public ProjectServiceImpl(BitbucketService bitbucketService, JiraService jiraService,
28-
OpenshiftService openshiftService,
29-
GenerateProjectKeyService generateProjectKeyService) {
30-
this.bitbucketService = bitbucketService;
31-
this.jiraService = jiraService;
32-
this.openshiftService = openshiftService;
33-
this.generateProjectKeyService = generateProjectKeyService;
34-
}
3526

3627
@Override
3728
public CreateProjectResponse createProject(CreateProjectRequest request) {

service-projects/src/test/java/org/opendevstack/apiservice/serviceproject/service/impl/ProjectServiceImplTest.java

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)