Refactor ProjectCreationCommandBuilder and ProjectsFacadeImpl: improve default value handling and streamline workflow parameter mapping

Author: angelmp01

api-project/src/main/java/org/opendevstack/apiservice/project/facade/impl/ProjectCreationCommandBuilder.java

@@ -34,17 +34,20 @@ public ProjectCreationCommand build(CreateProjectRequest request, ClientAppEntit
         String projectFlavor = firstNonBlank(request.getProjectFlavor(), flavor.getName());
         String configurationItem = firstNonBlank(request.getConfigurationItem(), flavor.getConfigItem());
         String owner = firstNonBlank(request.getOwner(), flavor.getProjectOwner());
+        String x2account = firstNonBlank(request.getX2OdsAccount(), flavor.getServiceAccount());
         String location = firstNonBlank(request.getLocation(), flavor.getLocation());
         String projectKey = resolveProjectKey(request.getProjectKey(), flavor);
+        String projectName = firstNonBlank(request.getProjectName(), projectKey);
+        String projectDescription = firstNonBlank(request.getProjectDescription(), "project " + projectFlavor);
 
         return new ProjectCreationCommand(
                 projectKey,
-                request.getProjectName(),
-                request.getProjectDescription(),
+                projectName,
+                projectDescription,
                 projectFlavor,
                 configurationItem,
                 location,
-                request.getX2OdsAccount(),
+                x2account,
                 owner,
                 clientApp.getId());
     }

api-project/src/main/java/org/opendevstack/apiservice/project/facade/impl/ProjectsFacadeImpl.java

@@ -19,6 +19,7 @@
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Component;
 
+import java.util.Map;
 import java.util.UUID;
 
 @Component("apiProjectFacadeImpl")
@@ -71,12 +72,11 @@ public CreateProjectResponse createProject(CreateProjectRequest request, UUID cl
 
         ProjectResponse project = projectService.saveProject(projectRequest);
 
+        String projectId = project.getProjectId().toString();
+        Map<String, Object> workflowParameters = automationParametersMapper.toWorkflowParameters(command, projectId);
+        
         AutomationExecutionResult automationExecutionResult = automationPlatformService
-                .executeWorkflow(
-                    createProjectWorkflow, 
-                    automationParametersMapper.toWorkflowParameters(
-                            command,
-                            project.getProjectId().toString()));
+                .executeWorkflow(createProjectWorkflow, workflowParameters);
 
         if (automationExecutionResult.isSuccessful()) {
             return projectCreationResponseMapper.toSuccessResponse(command, project);