Refactor component creation and retrieval logic; enhance error handli… #17
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package org.opendevstack.apiservice.project.config; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonInclude; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import org.openapitools.jackson.nullable.JsonNullable; | ||
| import org.openapitools.jackson.nullable.JsonNullableModule; | ||
| import org.springframework.boot.autoconfigure.jackson.Jackson2ObjectMapperBuilderCustomizer; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| public class JsonNullableConfig { | ||
|
|
||
| @Bean | ||
| public Jackson2ObjectMapperBuilderCustomizer jsonNullableCustomizer() { | ||
| return builder -> { | ||
| builder.modulesToInstall(JsonNullableModule.class); | ||
| builder.postConfigurer(this::configureJsonNullableInclusion); | ||
| }; | ||
| } | ||
|
|
||
| private void configureJsonNullableInclusion(ObjectMapper objectMapper) { | ||
| objectMapper.configOverride(JsonNullable.class) | ||
| .setInclude(JsonInclude.Value.construct(JsonInclude.Include.NON_ABSENT, JsonInclude.Include.NON_ABSENT)); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,54 @@ | ||
| package org.opendevstack.apiservice.project.controller; | ||
|
|
||
| import org.opendevstack.apiservice.project.exception.ComponentErrorKey; | ||
| import org.opendevstack.apiservice.project.model.CreateComponentResponse; | ||
| import org.springframework.http.HttpStatus; | ||
|
|
||
| public final class ComponentsResponseFactory { | ||
|
|
||
| private ComponentsResponseFactory() { | ||
| } | ||
|
|
||
| public static CreateComponentResponse entityCreated(String projectId, String componentId) { | ||
| String path = String.format("/api/pub/v0/projects/%s/components/%s", projectId, componentId); | ||
| return ok(path, "Component created"); | ||
| } | ||
|
|
||
| public static CreateComponentResponse badRequest(String path, String message, ComponentErrorKey errorKey) { | ||
| return buildResponse(HttpStatus.BAD_REQUEST, errorKey, path, message); | ||
| } | ||
|
|
||
| public static CreateComponentResponse forbidden(String path, String message, ComponentErrorKey errorKey) { | ||
| return buildResponse(HttpStatus.FORBIDDEN, errorKey, path, message); | ||
| } | ||
|
|
||
| public static CreateComponentResponse notFound(String path, String message, ComponentErrorKey errorKey) { | ||
| return buildResponse(HttpStatus.NOT_FOUND, errorKey, path, message); | ||
| } | ||
|
|
||
| public static CreateComponentResponse internalError(String path, String message, ComponentErrorKey errorKey) { | ||
| return buildResponse(HttpStatus.INTERNAL_SERVER_ERROR, errorKey, path, message); | ||
| } | ||
|
|
||
| private static CreateComponentResponse buildResponse(HttpStatus httpStatus, ComponentErrorKey errorKey, String path, | ||
| String message) { | ||
| CreateComponentResponse response = new CreateComponentResponse(); | ||
| response.setTimestamp(System.currentTimeMillis()); | ||
| response.setHttpStatus(httpStatus.name()); | ||
| response.setErrorKey(errorKey.getKey()); | ||
| response.setError(errorKey.getMessage()); | ||
| response.setMessage(message); | ||
| response.setPath(path); | ||
| return response; | ||
| } | ||
|
|
||
| public static CreateComponentResponse ok(String path, String message) { | ||
| CreateComponentResponse response = new CreateComponentResponse(); | ||
| response.setTimestamp(System.currentTimeMillis()); | ||
| response.setHttpStatus(HttpStatus.OK.name()); | ||
| response.setErrorKey(ComponentErrorKey.OK.getKey()); | ||
| response.setMessage(message); | ||
| response.setPath(path); | ||
| return response; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if it is needed for the new Markeplace 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done