Skip to content

Commit 8d40c11

Browse files
String literals should not be duplicated java:S1192 (#6)
1 parent fd6f6eb commit 8d40c11

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

src/main/java/org/opendevstack/component_provisioner/server/mappers/EntitiesMapper.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
@Slf4j
2828
public class EntitiesMapper {
2929
private static final ModelMapper MAPPER = new ModelMapper();
30+
public static final String WORKFLOW = "workflow";
3031
private static Converter<List<ProvisionActionParameter>, String> actionParamsToAwxWorkflowTemplateId; //NOSONAR
3132
private static Converter<List<ProvisionActionParameter>, String> actionParamsToAwxWorkflowTemplateExtraVars; //NOSONAR
3233

@@ -69,15 +70,15 @@ private static void setupConfigs() {
6970
private static void setupActionParamsConverters(ObjectMapper objectMapper) {
7071
actionParamsToAwxWorkflowTemplateId = ctx ->
7172
ctx.getSource().stream()
72-
.filter(p -> p.getName().equals("workflow") && p.getValue() instanceof String)
73+
.filter(p -> p.getName().equals(WORKFLOW) && p.getValue() instanceof String)
7374
.findFirst()
7475
.map(ProvisionActionParameter::getValue)
7576
.map(String::valueOf)
7677
.orElse(null);
7778

7879
createIncidentParamsToAwxWorkflowTemplateId = ctx ->
7980
ctx.getSource().stream()
80-
.filter(p -> p.getName().equals("workflow") && p.getValue() instanceof String)
81+
.filter(p -> p.getName().equals(WORKFLOW) && p.getValue() instanceof String)
8182
.findFirst()
8283
.map(CreateIncidentParameter::getValue)
8384
.map(String::valueOf)
@@ -87,7 +88,7 @@ private static void setupActionParamsConverters(ObjectMapper objectMapper) {
8788
actionParamsToAwxWorkflowTemplateExtraVars = ctx -> {
8889
// Turn into: "param1": "value1", "param2": "value2", ...
8990
var extraParams = StreamEx.of(ctx.getSource())
90-
.filter(p -> !p.getName().equals("workflow"))
91+
.filter(p -> !p.getName().equals(WORKFLOW))
9192
.mapToEntry(ProvisionActionParameter::getName, ProvisionActionParameter::getValue)
9293
.toMap();
9394

@@ -102,7 +103,7 @@ private static void setupActionParamsConverters(ObjectMapper objectMapper) {
102103
createIncidentParamsToAwxWorkflowTemplateExtraVars = ctx -> {
103104
// Turn into: "param1": "value1", "param2": "value2", ...
104105
var extraParams = StreamEx.of(ctx.getSource())
105-
.filter(p -> !p.getName().equals("workflow"))
106+
.filter(p -> !p.getName().equals(WORKFLOW))
106107
.mapToEntry(CreateIncidentParameter::getName, CreateIncidentParameter::getValue)
107108
.toMap();
108109

0 commit comments

Comments
 (0)