Skip to content

Commit fd6f6eb

Browse files
Added Failed status to supported status (#5)
* Added Failed status to supported status * Updated tests to fit the new status.
1 parent c4330b3 commit fd6f6eb

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

src/main/java/org/opendevstack/component_provisioner/server/controllers/model/ProjectComponentStatus.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
public enum ProjectComponentStatus {
66
CREATING,
77
CREATED,
8+
FAILED,
89
DELETING,
910
UNKNOWN;
1011

src/test/java/org/opendevstack/component_provisioner/server/controllers/ProvisionResultsApiControllerTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737

3838
@ExtendWith(MockitoExtension.class)
3939
class ProvisionResultsApiControllerTest {
40+
String exceptionMsg = "Status is not valid. It can only be CREATING, CREATED, FAILED, DELETING, UNKNOWN";
4041

4142
@Mock
4243
private AwxService awxService;
@@ -70,6 +71,7 @@ void givenAProvisionService_whenNotifyProvisioningCompletedIsCalled_thenReturnsO
7071
var catalogItemId = "catalogItemId";
7172
var componentUrl = "componentUrl";
7273

74+
7375
NotifyProvisioningStatusUpdateRequest notifyProvisioningCompletedRequest = new NotifyProvisioningStatusUpdateRequest();
7476
notifyProvisioningCompletedRequest.setComponentId(componentId);
7577
notifyProvisioningCompletedRequest.setCatalogItemId(catalogItemId);
@@ -207,7 +209,7 @@ void givenInvalidStatus_whenNotifyProvisioningStatusUpdate_then400OrInvalidRestE
207209
() -> provisionResultsApiController.notifyProvisioningStatusUpdate(projectKey, invalidStatus, request));
208210

209211
// then
210-
assertThat(exception.getMessage()).isEqualTo("Status is not valid. It can only be CREATING, CREATED, DELETING, UNKNOWN");
212+
assertThat(exception.getMessage()).isEqualTo(exceptionMsg);
211213
}
212214

213215
@Test
@@ -225,7 +227,7 @@ void givenLowercaseStatus_whenNotifyProvisioningStatusUpdate_thenEitherOkOrRejec
225227
() -> provisionResultsApiController.notifyProvisioningStatusUpdate(projectKey, statusLowercase, request));
226228

227229
// then
228-
assertThat(exception.getMessage()).isEqualTo("Status is not valid. It can only be CREATING, CREATED, DELETING, UNKNOWN");
230+
assertThat(exception.getMessage()).isEqualTo(exceptionMsg);
229231
}
230232

231233
}

0 commit comments

Comments
 (0)