[inmutable-collections-update] - Fix bug where we tried to update an …#22
Merged
sergio-soria-bi merged 2 commits intomasterfrom Apr 21, 2026
Merged
Conversation
…inmutable collection. At PlaceholderPostProcessor we are creating a new set of parameters using streams in java. Those streams frameworks create inmutable collections, but we later try to modify them. This cause a 500 error in the app.
sergio-soria-bi
requested review from
ivan-risueno,
jordivx and
sergio-esperalta-bi
| private ProvisionAction addParametersItem(ProvisionAction provisionAction, ProvisionActionParameter parameterItem) { | ||
| if (parameterItem == null) { | ||
| return provisionAction; | ||
| } else { |
There was a problem hiding this comment.
Extract the code outside the else block. This reduces one level of indentation, which improves readability.
if (parameterItem == null) {
return provisionAction;
}
// else block code |
…inmutable collection. At PlaceholderPostProcessor we are creating a new set of parameters using streams in java. Those streams frameworks create inmutable collections, but we later try to modify them. This cause a 500 error in the app.
|
hrcornejo
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[inmutable-collections-update] - Fix bug where we tried to update an inmutable collection.
At PlaceholderPostProcessor we are creating a new set of parameters using streams in java. Those streams frameworks create inmutable collections, but we later try to modify them. This cause a 500 error in the app.