token as a secret instead of plain env param

Author: BraisVQ

configuration-sample/ods-core.env.sample

@@ -426,7 +426,7 @@ OPENTELEMETRY_COLLECTOR_GOMEMLIMIT=128MiB
 OPENTELEMETRY_COLLECTOR_OTLP_API_ENDPOINT=https://fake-jaeger/v1/traces
 
 # The Authorization Token used to authenticate requests sent to the OTLP_API_ENDPOINT
-OPENTELEMETRY_COLLECTOR_OTLP_API_TOKEN=Bearer fakeJaegerIDToken
+OPENTELEMETRY_COLLECTOR_OTLP_API_TOKEN=Api-Token fakeJaegerIDToken
 
 # The Host of the Opentelemetry Collector
 OPENTELEMETRY_COLLECTOR_INGRESS_HOST=fake.opentelemetry-collector.com

opentelemetry-collector/chart/templates/deployment.yaml

@@ -26,9 +26,16 @@ spec:
         {{- end }}
         env:
         {{- range .Values.collector.env }}
+        {{- if ne .name "OPENTELEMETRY_COLLECTOR_OTLP_API_TOKEN" }}
         - name: {{ .name }}
           value: "{{ .value }}"
         {{- end }}
+        {{- end }}
+        - name: OPENTELEMETRY_COLLECTOR_OTLP_API_TOKEN
+          valueFrom:
+            secretKeyRef:
+              name: {{ .Values.collector.name }}-secret
+              key: otlp-api-token
         volumeMounts:
         {{- range .Values.collector.volumeMounts }}
         - name: {{ .name }}

opentelemetry-collector/chart/templates/secret.yaml

@@ -0,0 +1,9 @@
+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ .Values.collector.name }}-secret
+  labels:
+    app: {{ .Values.collector.name }}
+type: Opaque
+data:
+  otlp-api-token: {{ .Values.collector.secretValue | b64enc }}

opentelemetry-collector/chart/values.yaml.template

@@ -35,8 +35,7 @@ collector:
       value: $OPENTELEMETRY_COLLECTOR_GOMEMLIMIT
     - name: OTLP_API_ENDPOINT
       value: $OPENTELEMETRY_COLLECTOR_OTLP_API_ENDPOINT
-    - name: OTLP_API_TOKEN
-      value: $OPENTELEMETRY_COLLECTOR_OTLP_API_TOKEN
+  secretValue: $OPENTELEMETRY_COLLECTOR_OTLP_API_TOKEN
   volumeMounts:
     - name: collector-config
       mountPath: /conf