Skip to content

Commit 08d6aa8

Browse files
authored
Update to cpp20 and update deps (#339)
1 parent 3da70c0 commit 08d6aa8

4 files changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/build_test.yml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,10 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
config:
25-
- { os: ubuntu-22.04, cc: clang, cxx: clang++ }
26-
- { os: ubuntu-22.04, cc: gcc, cxx: g++ }
27-
- { os: macos-12, cc: clang, cxx: clang++ }
28-
- { os: windows-2022 }
29-
- { os: ubuntu-20.04, cc: clang, cxx: clang++ } # TODO remove; but there is no firefox in 22.04 yet
25+
- { os: ubuntu-22.04, compiler: clang, cc: clang-15, cxx: clang++-15 }
26+
- { os: ubuntu-22.04, compiler: gcc, cc: gcc-13, cxx: g++-13 }
27+
- { os: macos-12, compiler: clang, cc: clang, cxx: clang++ }
28+
- { os: windows-2022, compiler: msvc }
3029

3130
steps:
3231
- name: ubuntu install ccache
@@ -56,9 +55,9 @@ jobs:
5655
~/.conan/data
5756
C:/.conan
5857
C:/Users/runneradmin/.conan/data
59-
key: ${{ matrix.config.os }}-${{ matrix.config.cxx }}-${{ env.CCACHE_KEY_SUFFIX }}
58+
key: ${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ env.CCACHE_KEY_SUFFIX }}
6059
restore-keys: |
61-
${{ matrix.config.os }}-${{ matrix.config.cxx }}-
60+
${{ matrix.config.os }}-${{ matrix.config.compiler }}-
6261
6362
- name: checkout
6463
uses: actions/checkout@v2
@@ -74,7 +73,7 @@ jobs:
7473
- name: upload binaries
7574
uses: actions/upload-artifact@v2
7675
with:
77-
name: bin-${{ matrix.config.os }}-${{ matrix.config.cxx }}
76+
name: bin-${{ matrix.config.os }}-${{ matrix.config.compiler }}
7877
path: |
7978
build/test/odr_test
8079
@@ -85,8 +84,8 @@ jobs:
8584
fail-fast: true
8685
matrix:
8786
config:
88-
- { os: ubuntu-20.04, bin: bin-ubuntu-20.04-clang++ }
89-
- { os: macos-12, bin: bin-macos-12-clang++ }
87+
- { os: ubuntu-22.04, bin: bin-ubuntu-22.04-clang }
88+
- { os: macos-12, bin: bin-macos-12-clang }
9089

9190
steps:
9291
- name: ubuntu install tidy

CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cmake_minimum_required(VERSION 3.12.4)
22

33
project(odr LANGUAGES C CXX)
4-
set(CMAKE_CXX_STANDARD 17)
4+
set(CMAKE_CXX_STANDARD 20)
55
set(CMAKE_CXX_STANDARD_REQUIRED ON)
66
set(CMAKE_CXX_EXTENSIONS OFF)
77

@@ -39,7 +39,6 @@ if (NOT DEFINED CONAN_EXPORTED)
3939
conan_cmake_install(PATH_OR_REFERENCE ".."
4040
BUILD missing
4141
SETTINGS ${settings}
42-
SETTINGS compiler.cppstd=${CMAKE_CXX_STANDARD}
4342
ENV CC=${CMAKE_C_COMPILER}
4443
ENV CXX=${CMAKE_CXX_COMPILER})
4544
#include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)

conanfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ class OpenDocumentCoreConan(ConanFile):
2121

2222
exports_sources = ["cli/*", "cmake/*", "src/*", "CMakeLists.txt"]
2323

24-
requires = ["pugixml/1.11", "cryptopp/8.5.0", "miniz/2.1.0", "nlohmann_json/3.10.4",
24+
requires = ["pugixml/1.14", "cryptopp/8.8.0", "miniz/2.1.0", "nlohmann_json/3.11.3",
2525
"vincentlaucsb-csv-parser/2.1.3", "uchardet/0.0.7"]
26-
build_requires = ["gtest/1.11.0"]
26+
build_requires = ["gtest/1.14.0"]
2727
generators = "cmake_paths", "cmake_find_package"
2828

2929
_cmake = None

src/odr/internal/crypto/crypto_util.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#include <odr/internal/crypto/crypto_util.hpp>
22

3+
#include <cstdint>
4+
35
#include <cryptopp/aes.h>
46
#include <cryptopp/base64.h>
57
#include <cryptopp/blowfish.h>

0 commit comments

Comments
 (0)