PDF: const-qualify scalar by-value constructor params (#576)

* PDF: const-qualify scalar by-value constructor params

Add top-level const to the cheap scalar by-value parameters `n`
(ExponentialFunction) and `bits_per_sample` (SampledFunction), matching
the codebase convention of const-qualifying scalar params in definitions.
Object/vector params stay non-const because they are std::move'd into
members, so adding const would defeat the move.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: andiwand

src/odr/internal/pdf/pdf_document_element.hpp

@@ -209,7 +209,7 @@ class CodeRange {
     using reference = std::uint32_t;
 
     Iterator() = default;
-    Iterator(const char *position, std::size_t width)
+    Iterator(const char *position, const std::size_t width)
         : m_position{position}, m_width{width} {}
 
     std::uint32_t operator*() const {
@@ -239,7 +239,7 @@ class CodeRange {
     std::size_t m_width{1};
   };
 
-  CodeRange(std::string_view codes, std::size_t width)
+  CodeRange(const std::string_view codes, const std::size_t width)
       : m_codes{codes}, m_width{width} {}
 
   // `data()` is used as a bounded byte range delimited by `end()`, not as a

src/odr/internal/pdf/pdf_function.cpp

@@ -46,7 +46,8 @@ double interpolate(const double x, const double a0, const double a1,
 class ExponentialFunction final : public Function {
 public:
   ExponentialFunction(std::vector<double> domain, std::vector<double> range,
-                      std::vector<double> c0, std::vector<double> c1, double n)
+                      std::vector<double> c0, std::vector<double> c1,
+                      const double n)
       : Function(std::move(domain), std::move(range)), m_c0{std::move(c0)},
         m_c1{std::move(c1)}, m_n{n} {}
 
@@ -115,7 +116,8 @@ class StitchingFunction final : public Function {
 class SampledFunction final : public Function {
 public:
   SampledFunction(std::vector<double> domain, std::vector<double> range,
-                  std::vector<std::size_t> size, std::int32_t bits_per_sample,
+                  std::vector<std::size_t> size,
+                  const std::int32_t bits_per_sample,
                   std::vector<double> encode, std::vector<double> decode,
                   std::string samples)
       : Function(std::move(domain), std::move(range)), m_size{std::move(size)},