One pass is sufficient for screenshots; style check on scripts (#902)

* One pass is sufficient for screenshots

* check script conventions

Author: mccalluc

scripts/deploy.sh

@@ -1,12 +1,12 @@
 #!/bin/bash
 
+set -euo pipefail
+
 die() {
   printf '%s\n' "$*" >&2
   exit 1
 }
 
-set -euo pipefail
-
 echo "Check git..."
 
 git pull

scripts/screenshots.sh

@@ -1,3 +1,6 @@
 #!/bin/bash
 
-SCREENSHOTS=1 pytest -k test_local_app_downloads -vv
+set -euo pipefail
+
+# Test is parameterized: We only need one pass, so download the README.
+SCREENSHOTS=1 pytest -k 'test_local_app_downloads and README' -vv

tests/test_misc.py

@@ -1,6 +1,7 @@
 import re
 import subprocess
 from pathlib import Path
+from stat import S_IXUSR as user_exec_mask
 
 import pytest
 
@@ -66,6 +67,16 @@ def test_python_min_version(rel_path):
         assert not re.search(r"3\.1[^0]", text)
 
 
+@pytest.mark.parametrize(
+    "script_path",
+    (package_root.parent / "scripts").glob("*.sh"),
+    ids=lambda path: path.name,
+)
+def test_bash_scripts(script_path: Path):
+    assert script_path.stat().st_mode & user_exec_mask  # type: ignore
+    assert script_path.read_text().startswith("#!/bin/bash\n\nset -euo pipefail")
+
+
 def get_file_paths() -> list[Path]:
     # TODO: Is there a package that respects .gitignore?
     top_level_paths = [