Skip to content

feat: globaloverride for gaid and gakey#335

Open
krishnaGajabi wants to merge 1 commit into
openebs:developfrom
krishnaGajabi:hpgachanges
Open

feat: globaloverride for gaid and gakey#335
krishnaGajabi wants to merge 1 commit into
openebs:developfrom
krishnaGajabi:hpgachanges

Conversation

@krishnaGajabi
Copy link
Copy Markdown
Contributor

@krishnaGajabi krishnaGajabi commented May 29, 2026

Why is this PR required? What issue does it fix?:
This PR implements Global Override behvaiour for gaid and gakey to be consistent with other local engine charts

What this PR does?:
This PR implements Global Override behvaiour for gaid and gakey to be consistent with other local engine charts

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::
did a helm template test on the chart manually

without anything set: no values are rendered
with global and local values set: global values win
with local values set: local is applied
Repeated the above procedure with localpv.nodeDeployment.enabled=true and observed similar results

@krishnaGajabi krishnaGajabi requested a review from a team as a code owner May 29, 2026 04:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.00%. Comparing base (f5a1e8b) to head (8004564).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #335   +/-   ##
========================================
  Coverage    54.00%   54.00%           
========================================
  Files            1        1           
  Lines          474      474           
========================================
  Hits           256      256           
  Misses         209      209           
  Partials         9        9           
Flag Coverage Δ
integrationtests 54.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant