feat: Enable single stack deployments in Helm chart by jochenseeber · Pull Request #828 · openebs/mayastor-extensions

jochenseeber · 2026-03-31T10:59:18Z

Description

Add a global ipFamily setting to the Helm chart that controls IP family
configuration for all chart-managed Kubernetes Services and adjusts container
bind addresses accordingly.

The setting accepts three values:

ipv4 -- IPv4 SingleStack, services bind to 0.0.0.0
ipv6 -- IPv6 SingleStack, services bind to ::
both (default) -- PreferDualStack with IPv4 and IPv6, services bind to ::

Two new helper templates are added to _helpers.tpl:

service_ip_family -- generates ipFamilyPolicy and ipFamilies fields
for Service specs
bind_address -- returns the appropriate bind address (0.0.0.0 or ::)

All four chart-managed Services now include the service_ip_family helper,
and four hardcoded [::] bind addresses in container args are replaced with
the bind_address helper.

Invalid values (including empty string) are rejected at template time with an error message.

Motivation and Context

The chart previously hardcoded [::] as the bind address and did not set
ipFamilyPolicy or ipFamilies on any Service. This made deployments on
IPv4-only fail, with no way to correctly configure the components.

Regression

No

How Has This Been Tested?

Verified with helm template for all supported values:

Default (both): All 4 Services render with ipFamilyPolicy: PreferDualStack and ipFamilies: [IPv4, IPv6]. Bind addresses render as
[::].
ipv4: All 4 Services render with ipFamilyPolicy: SingleStack and
ipFamilies: [IPv4]. Bind addresses render as [0.0.0.0].
ipv6: All 4 Services render with ipFamilyPolicy: SingleStack and
ipFamilies: [IPv6]. Bind addresses render as [::].
Invalid value: helm template --set ipFamily=invalid fails with error
invalid ipFamily value "invalid" -- valid values: ipv4, ipv6, both.
Empty string: helm template --set ipFamily="" fails with the same
validation error.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project (afaik :).
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added unit tests to cover my changes.

tiagolobocastro · 2026-04-20T21:09:46Z

@mergify rebase

mergify · 2026-04-20T21:09:59Z

rebase

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@jochenseeber needs to authorize modification on its head branch.

tiagolobocastro · 2026-04-20T21:10:36Z

@jochenseeber sorry about the delay, could you please rebase?

Signed-off-by: Jochen Seeber <jochen@seeber.me>

tiagolobocastro · 2026-04-22T13:21:10Z

@jochenseeber , could you please take a look at the failure:


Run nix-shell ./scripts/helm/shell.nix --run "./scripts/helm/install.sh --pull-policy IfNotPresent --wait"
Installing Mayastor Chart
+ helm install mayastor ./scripts/helm/../../chart -n mayastor --create-namespace --set=etcd.livenessProbe.initialDelaySeconds=5,etcd.readinessProbe.initialDelaySeconds=5,etcd.replicaCount=1 --set=obs.callhome.enabled=true,obs.callhome.sendReport=false,localpv-provisioner.analytics.enabled=false --set=eventing.enabled=true,nats.cluster.enabled=false,nats.cluster.replicas=1 --set=loki.loki.commonConfig.replication_factor=1 --set=loki.singleBinary.replicas=1 --set=loki.minio.mode=standalone --set=loki.minio.enabled=true,loki.minio.replicas=1 --wait --timeout 5m --set image.pullPolicy=IfNotPresent
Error: INSTALLATION FAILED: 4 errors occurred:
	* Service "mayastor-obs-callhome-stats" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster
	* Service "mayastor-api-rest" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster
	* Service "mayastor-metrics-exporter-io-engine" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster
	* Service "mayastor-agent-core" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster

niladrih

Few minor comments. Looks good overall.

niladrih · 2026-04-23T09:40:05Z

+Valid values: "ipv4", "ipv6", "both"
+*/}}
+{{- define "service_ip_family" -}}
+{{- if eq .Values.ipFamily "ipv4" }}


Should we do the comparison after a run through tostring, lower and trim?

niladrih · 2026-04-23T09:40:32Z

+ipFamilyPolicy: SingleStack
+ipFamilies:
+  - IPv4
+{{- else if eq .Values.ipFamily "ipv6" }}


Same. Maybe use tostring, lower and trim?

niladrih · 2026-04-23T09:41:45Z

+ipFamilyPolicy: SingleStack
+ipFamilies:
+  - IPv6
+{{- else if eq .Values.ipFamily "both" }}


Maybe tostring, lower and trim here as well.

niladrih · 2026-04-23T09:42:17Z

 | io_engine.&ZeroWidthSpace;target.&ZeroWidthSpace;nvmf.&ZeroWidthSpace;ptpl | Reservations Persist Through Power Loss State | `true` |
 | io_engine.&ZeroWidthSpace;target.&ZeroWidthSpace;nvmf.&ZeroWidthSpace;rdma | Enable RDMA Capability of Mayastor nvmf target to take RDMA connections if the cluster nodes have RDMA device(s) configured from RNIC. | <pre>{<br>"enabled":false<br>}</pre> |
 | io_engine.&ZeroWidthSpace;tolerations | Set tolerations, overrides global | `[]` |
+| ipFamily | IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both" (default). | `"both"` |


nit: the (default) is redundant as the default value is mentioned in the very next column.

Suggested change

| ipFamily | IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both" (default). | `"both"` |

| ipFamily | IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both". | `"both"` |

tiagolobocastro · 2026-05-07T10:00:29Z

@jochenseeber , could you please take a look at the failure:


Run nix-shell ./scripts/helm/shell.nix --run "./scripts/helm/install.sh --pull-policy IfNotPresent --wait"
Installing Mayastor Chart
+ helm install mayastor ./scripts/helm/../../chart -n mayastor --create-namespace --set=etcd.livenessProbe.initialDelaySeconds=5,etcd.readinessProbe.initialDelaySeconds=5,etcd.replicaCount=1 --set=obs.callhome.enabled=true,obs.callhome.sendReport=false,localpv-provisioner.analytics.enabled=false --set=eventing.enabled=true,nats.cluster.enabled=false,nats.cluster.replicas=1 --set=loki.loki.commonConfig.replication_factor=1 --set=loki.singleBinary.replicas=1 --set=loki.minio.mode=standalone --set=loki.minio.enabled=true,loki.minio.replicas=1 --wait --timeout 5m --set image.pullPolicy=IfNotPresent
Error: INSTALLATION FAILED: 4 errors occurred:
	* Service "mayastor-obs-callhome-stats" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster
	* Service "mayastor-api-rest" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster
	* Service "mayastor-metrics-exporter-io-engine" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster
	* Service "mayastor-agent-core" is invalid: spec.ipFamilies[1]: Invalid value: "IPv6": not configured on this cluster

a gentle ping @jochenseeber

jochenseeber requested a review from a team as a code owner March 31, 2026 10:59

jochenseeber force-pushed the develop branch 2 times, most recently from 58f43c6 to c91ec10 Compare March 31, 2026 15:07

tiagolobocastro reviewed Apr 2, 2026

View reviewed changes

Comment thread chart/templates/mayastor/agents/core/agent-core-deployment.yaml Outdated

jochenseeber force-pushed the develop branch 2 times, most recently from f9e187d to ac13637 Compare April 15, 2026 08:58

tiagolobocastro requested review from Abhinandan-Purkait and niladrih April 20, 2026 21:10

Abhinandan-Purkait approved these changes Apr 22, 2026

View reviewed changes

feat: Enable single stack deployments in Helm chart

abfb14a

Signed-off-by: Jochen Seeber <jochen@seeber.me>

jochenseeber force-pushed the develop branch from ac13637 to abfb14a Compare April 22, 2026 11:34

tiagolobocastro added this pull request to the merge queue Apr 22, 2026

tiagolobocastro approved these changes Apr 22, 2026

View reviewed changes

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026

niladrih reviewed Apr 23, 2026

View reviewed changes

tiagolobocastro added the ci/test label May 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enable single stack deployments in Helm chart#828

feat: Enable single stack deployments in Helm chart#828
jochenseeber wants to merge 1 commit into
openebs:developfrom
CaperWhite:develop

jochenseeber commented Mar 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

tiagolobocastro commented Apr 20, 2026

Uh oh!

mergify Bot commented Apr 20, 2026

Uh oh!

tiagolobocastro commented Apr 20, 2026

Uh oh!

Uh oh!

tiagolobocastro commented Apr 22, 2026

Uh oh!

niladrih left a comment

Uh oh!

niladrih Apr 23, 2026

Uh oh!

niladrih Apr 23, 2026

Uh oh!

niladrih Apr 23, 2026

Uh oh!

niladrih Apr 23, 2026

Uh oh!

tiagolobocastro commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	\| ipFamily \| IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both" (default). \| `"both"` \|
	\| ipFamily \| IP family for services and bind addresses. Valid values: "ipv4", "ipv6", "both". \| `"both"` \|

Conversation

jochenseeber commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

Uh oh!

tiagolobocastro commented Apr 20, 2026

Uh oh!

mergify Bot commented Apr 20, 2026

❌ Pull request can't be updated with latest base branch changes

Uh oh!

tiagolobocastro commented Apr 20, 2026

Uh oh!

Uh oh!

tiagolobocastro commented Apr 22, 2026

Uh oh!

niladrih left a comment

Choose a reason for hiding this comment

Uh oh!

niladrih Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

niladrih Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

niladrih Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

niladrih Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

tiagolobocastro commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jochenseeber commented Mar 31, 2026 •

edited

Loading